|
|
Created:
6 years, 5 months ago by sergeyv Modified:
6 years, 4 months ago Reviewers:
johnme CC:
blink-reviews Base URL:
svn://svn.chromium.org/blink/trunk Project:
blink Visibility:
Public. |
DescriptionRevert of Mark 63 inspector/ tests as flaky on Linux ASAN (https://codereview.chromium.org/407113002/)
Reason for revert:
Since patch https://codereview.chromium.org/399383005 has been successfully landed, lets try revert this one, test should be ok now
Original issue's description:
> Mark 63 inspector/ tests as flaky on Linux ASAN
>
> (and clean up old expectations for these tests)
>
> BUG=395997, 395676
> TBR=sergeyv@chromium.org
> NOTRY=true
> NOTREECHECKS=true
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178638
TBR=johnme@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=395997, 395676
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179111
Patch Set 1 #Patch Set 2 : #Messages
Total messages: 10 (0 generated)
Created Revert of Mark 63 inspector/ tests as flaky on Linux ASAN
Although marked as flaky, the tests continue to be run and to gather data for the flakiness dashboard. How about we wait for the ASAN bots on [1] to go green for 3 or more runs in a row before we revert this? [1]: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ins...
On 2014/07/22 14:16:54, johnme wrote: > Although marked as flaky, the tests continue to be run and to gather data for > the flakiness dashboard. How about we wait for the ASAN bots on [1] to go green > for 3 or more runs in a row before we revert this? > > [1]: > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ins... Sure.
The CQ bit was checked by sergeyv@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/413473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for LayoutTests/ASANExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/ASANExpectations Hunk #1 succeeded at 57 (offset 1 line). Hunk #2 FAILED at 86. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/ASANExpectations.rej Patch: LayoutTests/ASANExpectations Index: LayoutTests/ASANExpectations diff --git a/LayoutTests/ASANExpectations b/LayoutTests/ASANExpectations index 5118fe1d0b655655975b7337ad19c3160321a79c..1b103455d0d3fbc4c55decd98354cff4294c749e 100644 --- a/LayoutTests/ASANExpectations +++ b/LayoutTests/ASANExpectations @@ -56,6 +56,11 @@ crbug.com/231357 [ Linux ] virtual/softwarecompositing/video-page-visibility.html [ ImageOnlyFailure ] crbug.com/231357 [ Linux ] compositing/video-page-visibility.html [ ImageOnlyFailure ] +# These tests flakily timeout on the ASAN bot +crbug.com/247466 [ Linux ] inspector/debugger/live-edit-breakpoints.html [ Pass Timeout ] +crbug.com/247466 [ Linux ] inspector/debugger/reveal-not-skipped.html [ Pass Timeout ] +crbug.com/247466 [ Linux ] inspector/profiler/heap-snapshot-summary-sorting-fields.html [ Pass Timeout ] + # These have been failing since at least chrome r203901, blink r151723 (no memory errors, just text failure): crbug.com/231357 [ Linux ] editing/execCommand/switch-list-type-with-orphaned-li.html [ Failure ] crbug.com/231357 [ Linux ] perf/mouse-event.html [ Crash ] @@ -81,76 +86,3 @@ crbug.com/385015 [ Linux ] fast/frames/iframe-onload-remove-self-no-crash.html [ Failure ] crbug.com/385015 [ Linux ] fast/loader/create-frame-in-DOMContentLoaded.html [ Failure ] crbug.com/385015 [ Linux ] fast/loader/frame-creation-removal.html [ Failure ] - -# Flakily crash on Linux ASAN bots. -crbug.com/395997 [ Linux ] inspector/console/console-log-side-effects.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/elements/styles/style-rule-from-imported-stylesheet.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-expansion-preserved-when-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-show-next.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-shown-node-count-preserved-when-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-containment-show-next.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-containment-shown-node-count-preserved-when-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-containment-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-loader.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-statistics.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-search.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-show-next.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/sources/debugger/script-extract-outline.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/sources/debugger/script-formatter.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/sources/debugger/script-snippet-model.html [ Crash Pass ] - -# Flakily crash on Linux ASAN bots (and each timed out once, but not yet clear if they timeout flakily). -crbug.com/395997 [ Linux ] inspector/profiler/canvas2d/canvas2d-api-changes.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-dom-groups-change.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-show-all.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-expansion-preserved-when-sorting.html [ Crash Pass ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-retainers.html [ Crash Pass ] -crbug.com/247466 [ Linux ] inspector/profiler/heap-snapshot-summary-sorting-fields.html [ Crash Pass ] - -# Flakily crash and timeout on Linux ASAN bots (crbug.com/395997 and crbug.com/395676 respectively). -crbug.com/395997 [ Linux ] inspector/device-emulation/device-emulation-320-2x.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/editor/text-editor-autocomplete.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/elements/styles/css-outline.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/elements/styles/cssom-media-insert-crash.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/elements/styles/style-formatter.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/canvas2d/canvas2d-gradient-capturing.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-comparison-sorting.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-containment-expansion-preserved-when-sorting.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-containment-show-all.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-shown-node-count-preserved-when-sorting.html [ Crash Pass Timeout ] -crbug.com/395997 [ Linux ] inspector/profiler/heap-snapshot-summary-sorting-instances.html [ Crash Pass Timeout ] - -# Flakily timeout on Linux ASAN bots (and each crashed once, but not yet clear if they crash flakily). -crbug.com/395676 [ Linux ] inspector/editor/text-editor-goto-matching-bracket.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/bidi-dom-tree.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/styles/add-new-rule-inline-style-csp.html [ Pass Timeout ] - -# Flakily timeout on Linux ASAN bots. -crbug.com/395676 [ Linux ] inspector/color.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/console/console-api-on-call-frame.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/console/console-big-array.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/console/console-format.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/console/console-stack-overflow.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/device-emulation/device-emulation-320-only-viewport.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/device-emulation/device-emulation-980-2x.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/device-emulation/device-emulation-restore.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/editor/text-editor-ctrl-d.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/breadcrumb-shadow-roots.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/edit-dom-actions-shadow.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/elements-panel-shadow-selection-on-refresh.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/set-outer-html-for-xhtml.xhtml [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/styles/css-live-edit.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/styles/inject-stylesheet.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/styles/pseudo-elements.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/elements/styles/styles-update-links.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/extensions/extensions-api.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/extensions/extensions-events.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/layers/layer-canvas-log.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/profiler/webgl/webgl-get-resource-state-buffer-data.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/sources/debugger/debug-inlined-scripts.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/sources/debugger/debugger-reload-on-pause.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/sources/debugger/debugger-step-into-custom-element-callbacks.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/sources/debugger/debugger-step-into-event-listener.html [ Pass Timeout ] -crbug.com/395676 [ Linux ] inspector/sources/debugger/dynamic-scripts-breakpoints.html [ Pass Timeout ]
The CQ bit was checked by sergeyv@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/413473002/60001
Message was sent while issue was closed.
Change committed as 179111 |