Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Issue 399383005: Scheduler: Don't shut down the scheduler too soon (Closed)

Created:
6 years, 5 months ago by Sami
Modified:
6 years, 5 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Scheduler: Don't shut down the scheduler too soon We shouldn't terminate the scheduler before ensuring background threads such as the HTML parser have been stopped. This is because those threads may schedule new work, leading to a crash as we're trying to post tasks into a non-existing scheduler. This patch moves the call to tear down the scheduler right before terminating blink's Platform abstraction and right after terminating WTF, as WTF also has a dependency on the scheduler (callOnMain). BUG=395420 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/web/WebKit.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Sami
PTAL Eric. Let me see if I can figure out a way to test this ...
6 years, 5 months ago (2014-07-21 14:14:19 UTC) #1
Sami
Jochen, can you have a look? I don't think there's a reasonable way to write ...
6 years, 5 months ago (2014-07-22 10:32:08 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 5 months ago (2014-07-22 10:54:13 UTC) #3
Sami
The CQ bit was checked by skyostil@chromium.org
6 years, 5 months ago (2014-07-22 11:12:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skyostil@chromium.org/399383005/1
6 years, 5 months ago (2014-07-22 11:12:50 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-22 12:07:23 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 12:45:39 UTC) #7
Message was sent while issue was closed.
Change committed as 178644

Powered by Google App Engine
This is Rietveld 408576698