Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 413393005: Subzero: Make Ice::Ostream a typedef for llvm::raw_ostream. (Closed)

Created:
6 years, 5 months ago by Jim Stichnoth
Modified:
6 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Make Ice::Ostream a typedef for llvm::raw_ostream. Previously Ostream was a class that wrapped a raw_ostream pointer, structured that way in case we wanted to wrap an alternate stream type. Also, Ostream used to include a Cfg pointer, but that had to go away when the Ostream became associated with the GlobalContext which persists beyond the Cfg lifetime, so the Cfg pointer was removed leaving only the raw_ostream. Since llvm::raw_ostream is supposed to be very lightweight, we can just give up the abstraction and equate it to Ice::Ostream. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=78282f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -41 lines) Patch
M src/IceDefs.h View 1 chunk +1 line, -20 lines 0 comments Download
M src/IceGlobalContext.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceGlobalContext.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceTypes.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/IceTypes.cpp View 1 chunk +4 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jim Stichnoth
6 years, 5 months ago (2014-07-25 22:50:57 UTC) #1
Karl
lgtm
6 years, 4 months ago (2014-07-27 23:51:13 UTC) #2
Jim Stichnoth
6 years, 4 months ago (2014-07-28 06:14:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r78282f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698