src/IceGlobalContext.cpp - Issue 413393005: Subzero: Make Ice::Ostream a typedef for llvm::raw_ostream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 413393005: Subzero: Make Ice::Ostream a typedef for llvm::raw_ostream. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index a7b1b64c2951f8780f7ad8304129539109f136e4..113ffc49ca5837a5273ef1b26246ab3d093ac296 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -330,8 +330,7 @@ Constant *GlobalContext::getConstantZero(Type Ty) {

case IceType_v4f32: {

IceString Str;

llvm::raw_string_ostream BaseOS(Str);

- Ostream OS(&BaseOS);

- OS << "Unsupported constant type: " << Ty;

+ BaseOS << "Unsupported constant type: " << Ty;

llvm_unreachable(BaseOS.str().c_str());

} break;

case IceType_void:

@@ -362,8 +361,7 @@ ConstantList GlobalContext::getConstantPool(Type Ty) const {