Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 413393003: Blink-in-JS: Implement internal APIs exposed only to private scripts (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index e63751c69f22b589e8a4994abb1cd0d4854772ea..e6e99ff9eebdb39177694b0ef76af1dcde7d22c6 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -62,7 +62,7 @@ template <typename T> void V8_USE(T) { }
attribute_setter_implemented_in_private_script
with context %}
{% for attribute in attributes if not attribute.constructor_type %}
-{% if not attribute.only_exposed_to_private_script %}
+{% if not attribute.is_implemented_in_private_script or not attribute.only_exposed_to_private_script %}
Jens Widell 2014/07/25 09:45:36 Use the new flag here too?
haraken 2014/07/25 09:58:19 Done.
{% for world_suffix in attribute.world_suffixes %}
{% if not attribute.has_custom_getter %}
{{attribute_getter(attribute, world_suffix)}}
@@ -91,7 +91,7 @@ template <typename T> void V8_USE(T) { }
method_implemented_in_private_script
with context %}
{% for method in methods %}
-{% if not method.only_exposed_to_private_script %}
+{% if not method.is_implemented_in_private_script or not method.only_exposed_to_private_script %}
Jens Widell 2014/07/25 09:45:36 And here.
haraken 2014/07/25 09:58:19 Done.
{% for world_suffix in method.world_suffixes %}
{% if not method.is_custom %}
{{generate_method(method, world_suffix)}}

Powered by Google App Engine
This is Rietveld 408576698