Chromium Code Reviews| Index: Source/bindings/scripts/v8_attributes.py |
| diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py |
| index 485991d8860483eee00f66dbb1d3a7236d874f38..99833dbe55d3a72be8a29f91e2b9dd3bc99a083c 100644 |
| --- a/Source/bindings/scripts/v8_attributes.py |
| +++ b/Source/bindings/scripts/v8_attributes.py |
| @@ -78,6 +78,9 @@ def attribute_context(interface, attribute): |
| includes.add('core/frame/LocalFrame.h') |
| includes.add('platform/ScriptForbiddenScope.h') |
| + # [OnlyExposedToPrivateScript] |
| + is_only_exposed_to_private_script = 'OnlyExposedToPrivateScript' in extended_attributes |
| + |
| if (base_idl_type == 'EventHandler' and |
| interface.name in ['Window', 'WorkerGlobalScope'] and |
| attribute.name == 'onerror'): |
| @@ -128,7 +131,7 @@ def attribute_context(interface, attribute): |
| 'is_unforgeable': 'Unforgeable' in extended_attributes, |
| 'measure_as': v8_utilities.measure_as(attribute), # [MeasureAs] |
| 'name': attribute.name, |
| - 'only_exposed_to_private_script': 'OnlyExposedToPrivateScript' in extended_attributes, |
| + 'only_exposed_to_private_script': is_only_exposed_to_private_script, |
| 'per_context_enabled_function': v8_utilities.per_context_enabled_function_name(attribute), # [PerContextEnabled] |
| 'private_script_v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value( |
| extended_attributes, 'v8Value', 'cppValue', isolate='scriptState->isolate()', used_in_private_script=True), |
| @@ -141,6 +144,7 @@ def attribute_context(interface, attribute): |
| if 'ReflectOnly' in extended_attributes else None, |
| 'runtime_enabled_function': v8_utilities.runtime_enabled_function_name(attribute), # [RuntimeEnabled] |
| 'setter_callback': setter_callback_name(interface, attribute), |
| + 'should_be_exposed_to_script': not is_implemented_in_private_script or not is_only_exposed_to_private_script, |
|
Jens Widell
2014/07/25 09:45:36
Might be a matter of taste, but I'd prefer "not(A
haraken
2014/07/25 09:58:19
Done.
|
| 'v8_type': v8_types.v8_type(base_idl_type), |
| 'world_suffixes': ['', 'ForMainWorld'] |
| if 'PerWorldBindings' in extended_attributes |