Resubmit: Open the WrenchMenu on mouseover when dragging a browser action

Resubmit: Open the WrenchMenu on mouseover when dragging a browser action

Original Patch: https://codereview.chromium.org/399143004
Reverted In: https://codereview.chromium.org/416903002/
This was reverted because the test was flaky on Vista. Resubmit with a fix.

------------------------

Open the WrenchMenu on mouseover when dragging a browser action

Enable dragging from the main container to the overflow container by opening the
wrench menu when hovering over the button while dragging a browser action. This
also requires keeping the menu open while the drag is happening.

Note: this doesn't fix drag calculations for the overflow menu.
In an effort to keep these patches small, that will come later.

BUG=393038
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285634

[Devlin, 2014-07-24 23:18:03]

Sorry to bug you with this one again...

https://codereview.chromium.org/413323002/diff/40001/chrome/browser/ui/views/...
File chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc (right):

https://codereview.chromium.org/413323002/diff/40001/chrome/browser/ui/views/...
chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc:148:
ASSERT_EQ(1u, browser_actions()->VisibleBrowserActions());
Judging from the test output in the revert CL, this ASSERT was occasionally
failing. This could happen if we reached the assert before the
BrowserActionsContainer finished animating, which is solved by disabling
animations for testing.

[sky, 2014-07-25 03:15:33]

LGTM - please run this a bunch of times locally to make sure it doesn't flake
anymore before landing again.

[Devlin, 2014-07-25 15:32:34]

On 2014/07/25 03:15:33, sky wrote:
> LGTM - please run this a bunch of times locally to make sure it doesn't flake
> anymore before landing again.

I've run it a hundred times or so locally on Win7 (and will do so again for good
measure), and it's unflaky.  Unfortunately, the flakiness was on Vista - which I
don't have a machine for, and we don't (as far as I can see) have a trybot. :/

[Devlin, 2014-07-25 16:34:03]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-07-25 16:34:43]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/413323002/...

[commit-bot: I haz the power, 2014-07-25 18:53:47]

Change committed as 285634