Resubmit: Open the WrenchMenu on mouseover when dragging a browser action

chrome/browser/ui/views/menu_view_drag_and_drop_test.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ui/views/menu_test_base.h"
 #include "chrome/test/base/interactive_test_utils.h"
 #include "ui/base/dragdrop/drag_drop_types.h"
 #include "ui/base/dragdrop/os_exchange_data.h"
+#include "ui/views/controls/menu/menu_controller.h"
 #include "ui/views/controls/menu/menu_item_view.h"
+#include "ui/views/controls/menu/menu_runner.h"
 #include "ui/views/controls/menu/submenu_view.h"
 #include "ui/views/view.h"
 
 namespace {
 
 // Borrowed from chrome/browser/ui/views/bookmarks/bookmark_bar_view_test.cc,
 // since these are also disabled on Linux for drag and drop.
 // TODO(erg): Fix DND tests on linux_aura. crbug.com/163931
 #if defined(OS_LINUX) && defined(USE_AURA)
 #define MAYBE(x) DISABLED_##x
@@ skipping 315 matching lines @@
   // delegate should not have been asked whether or not to close, and the menu
   // should simply be closed.
   EXPECT_TRUE(performed_in_menu_drop());
   EXPECT_FALSE(target_view()->dropped());
   EXPECT_FALSE(asked_to_close());
   EXPECT_FALSE(menu()->GetSubmenu()->IsShowing());
 
   Done();
 }
 
+// Test that an in-menu (i.e., entirely implemented in the menu code) closes the
+// menu automatically once the drag is complete, and does not ask the delegate
+// to stay open.
 VIEW_TEST(MenuViewDragAndDropTestTestInMenuDrag, MAYBE(TestInMenuDrag))
 
 class MenuViewDragAndDropTestNestedDrag : public MenuViewDragAndDropTest {
  public:
   MenuViewDragAndDropTestNestedDrag() {}
   virtual ~MenuViewDragAndDropTestNestedDrag() {}
 
  private:
   // MenuViewDragAndDropTest:
   virtual void DoTestWithMenuOpen() OVERRIDE;
@@ skipping 75 matching lines @@
   EXPECT_FALSE(performed_in_menu_drop());
   EXPECT_TRUE(asked_to_close());
   EXPECT_TRUE(menu()->GetSubmenu()->IsShowing());
 
   // Clean up.
   menu()->GetSubmenu()->Close();
 
   Done();
 }
 
+// Test that a nested drag (i.e. one via a child view, and not entirely
+// implemented in menu code) will consult the delegate before closing the view
+// after the drag.
 VIEW_TEST(MenuViewDragAndDropTestNestedDrag,
           MAYBE(MenuViewDragAndDropNestedDrag))
+
+class MenuViewDragAndDropForDropStayOpen : public MenuViewDragAndDropTest {
+ public:
+  MenuViewDragAndDropForDropStayOpen() {}
+  virtual ~MenuViewDragAndDropForDropStayOpen() {}
+
+ private:
+  // MenuViewDragAndDropTest:
+  virtual int GetMenuRunnerFlags() OVERRIDE;
+  virtual void DoTestWithMenuOpen() OVERRIDE;
+};
+
+int MenuViewDragAndDropForDropStayOpen::GetMenuRunnerFlags() {
+  return views::MenuRunner::HAS_MNEMONICS |
+         views::MenuRunner::NESTED_DRAG |
+         views::MenuRunner::FOR_DROP;
+}
+
+void MenuViewDragAndDropForDropStayOpen::DoTestWithMenuOpen() {
+  views::SubmenuView* submenu = menu()->GetSubmenu();
+  ASSERT_TRUE(submenu);
+  ASSERT_TRUE(submenu->IsShowing());
+
+  views::MenuController* controller = menu()->GetMenuController();
+  ASSERT_TRUE(controller);
+  EXPECT_FALSE(controller->IsCancelAllTimerRunningForTest());
+
+  Done();
+}
+
+// Test that if a menu is opened for a drop which is handled by a child view
+// that the menu does not immediately try to close.
+VIEW_TEST(MenuViewDragAndDropForDropStayOpen, MenuViewStaysOpenForNestedDrag)
+
+class MenuViewDragAndDropForDropCancel : public MenuViewDragAndDropTest {
+ public:
+  MenuViewDragAndDropForDropCancel() {}
+  virtual ~MenuViewDragAndDropForDropCancel() {}
+
+ private:
+  // MenuViewDragAndDropTest:
+  virtual int GetMenuRunnerFlags() OVERRIDE;
+  virtual void DoTestWithMenuOpen() OVERRIDE;
+};
+
+int MenuViewDragAndDropForDropCancel::GetMenuRunnerFlags() {
+  return views::MenuRunner::HAS_MNEMONICS | views::MenuRunner::FOR_DROP;
+}
+
+void MenuViewDragAndDropForDropCancel::DoTestWithMenuOpen() {
+  views::SubmenuView* submenu = menu()->GetSubmenu();
+  ASSERT_TRUE(submenu);
+  ASSERT_TRUE(submenu->IsShowing());
+
+  views::MenuController* controller = menu()->GetMenuController();
+  ASSERT_TRUE(controller);
+  EXPECT_TRUE(controller->IsCancelAllTimerRunningForTest());
+
+  Done();
+}
+
+// Test that if a menu is opened for a drop handled entirely by menu code, the
+// menu will try to close if it does not receive any drag updates.
+VIEW_TEST(MenuViewDragAndDropForDropCancel, MenuViewCancelsForOwnDrag)