Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9698)

Unified Diff: Tools/GardeningServer/ui/ct-failure-analyzer.html

Issue 413073004: Show non-Blink ranges in sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: add missing files Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-failure-analyzer.html
diff --git a/Tools/GardeningServer/ui/ct-failure-analyzer.html b/Tools/GardeningServer/ui/ct-failure-analyzer.html
index 51486ed3454fa849ee9d0f576849cad8ae124ab4..060cac85af3178aad5dfcf3d05cfbf4389bcfa14 100644
--- a/Tools/GardeningServer/ui/ct-failure-analyzer.html
+++ b/Tools/GardeningServer/ui/ct-failure-analyzer.html
@@ -80,18 +80,9 @@ found in the LICENSE file.
}.bind(this));
var groupedFailures = [];
-
- var oldestFailingRevision, newestPassingRevision;
- // FIXME: This is a workaround for the backend's bogus data when the blink
- // regression ranges have no overlap.
- if (group.merged_last_passing && group.merged_first_failing.blink > group.merged_last_passing.blink) {
- oldestFailingRevision = Number(group.merged_first_failing.blink);
- newestPassingRevision = Number(group.merged_last_passing.blink);
- }
-
Object.keys(failuresByReason, function(failureKey, resultByBuilder) {
var failure = JSON.parse(failureKey);
- groupedFailures.push(new CTFailure(failure.step, failure.reason, resultByBuilder, oldestFailingRevision, newestPassingRevision));
+ groupedFailures.push(new CTFailure(failure.step, failure.reason, resultByBuilder, group.merged_first_failing, group.merged_last_passing));
});
// FIXME: Make this a model class intead of a dumb object.

Powered by Google App Engine
This is Rietveld 408576698