Show non-Blink ranges in sheriff-o-matic.

Tools/GardeningServer/ui/ct-commit-list.html

Index: Tools/GardeningServer/ui/ct-commit-list.html
diff --git a/Tools/GardeningServer/ui/ct-commit-list.html b/Tools/GardeningServer/ui/ct-commit-list.html
index 3fc9727bdc8fad5edd13c42c2efaf44b4752cc49..6ff19411001d97a75351606affa88d8304cde383 100644
--- a/Tools/GardeningServer/ui/ct-commit-list.html
+++ b/Tools/GardeningServer/ui/ct-commit-list.html
@@ -13,28 +13,40 @@ found in the LICENSE file.
         display: block;
       }
     </style>
-    <template repeat="{{revision in _revisions}}">
-      <template if="{{commits[revision]}}">
-        <ct-commit data="{{commits[revision]}}"></ct-commit>
+    <template repeat="{{ repository in commits.commits | _repositories }}">
+      <template repeat="{{ commit in repository | _commits }}">

[abarth-chromium, 2014/07/29 16:22:26]

Do we want any sort of visual separation between commits in different repos?

[ojan, 2014/07/30 04:14:33]

Probably. I was punting on making the UI nice for a followup patch.

What I think we really want though is that the the list of commits for each repo
is collapsed by default, e.g. you'd see:
Blink 1234:1235
Chromium 333:345

And you could click on it for the range to expand.

+        <ct-commit data="{{ commit }}"></ct-commit>
       </template>
     </template>
   </template>
   <script>
     Polymer({
-      commits: {},
-      first: 0,
-      last: 0,
-      _revisions: [],
+      commits: null,
+      first: null,
+      last: null,
 
-      observe: {
-        first: '_update',
-        last: '_update',
+      _repositories: function(commits) {
+        if (!commits)
+          return [];
+        return Object.keys(commits).sort();
       },
 
-      _update: function() {
+      _commits: function(repository) {
+        var commits = [];
         if (!this.first || !this.last)
-          return;
-        this._revisions = Number.range(this.first, this.last).every();
+          return commits;
+
+        var first = Number(this.first[repository]);
+        var last = Number(this.last[repository]);
+        if (first == last)
+          return commits;
+
+        if (first > last) {
+          console.warn('Revision range is backwards, which is invalid:', first, last);
+          return commits;
+        }
+
+        return this.commits.range(repository, first + 1, last);
       },
     });
   </script>