Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 413023002: use a gcc version check in 4.9 warning workaround (Closed)

Created:
6 years, 5 months ago by Mostyn Bramley-Moore
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

use a gcc version check in 4.9 warning workaround Only disable the spurious warning on versions of GCC that need it, so we don't hide real warnings or break older compilers unnecessarily. Followup from https://codereview.chromium.org/384843002/ BUG=392872 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286347

Patch Set 1 #

Patch Set 2 : simplify ifdef, pop properly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M url/url_canon_ip.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@yuanlin, abarth: PTAL at this small improvement.
6 years, 5 months ago (2014-07-23 21:23:03 UTC) #1
yunlian
lgtm
6 years, 5 months ago (2014-07-23 21:31:45 UTC) #2
Mostyn Bramley-Moore
abarth: *ping*
6 years, 4 months ago (2014-07-28 07:29:27 UTC) #3
abarth-chromium
lgtm
6 years, 4 months ago (2014-07-29 16:41:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/413023002/20001
6 years, 4 months ago (2014-07-29 16:43:04 UTC) #5
Mostyn Bramley-Moore
The CQ bit was unchecked by mostynb@opera.com
6 years, 4 months ago (2014-07-29 21:39:34 UTC) #6
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 4 months ago (2014-07-29 21:39:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/413023002/20001
6 years, 4 months ago (2014-07-29 21:39:48 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 23:56:08 UTC) #9
Message was sent while issue was closed.
Change committed as 286347

Powered by Google App Engine
This is Rietveld 408576698