Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 384843002: url: work around a gcc warning bug. (Closed)

Created:
6 years, 5 months ago by yunlian
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

url: work around a gcc warning bug. Gcc 4.9 has a bug in reporting false positive array out of bound warning. This cl adds progma to disable the warning. BUG=chromium:392872 TEST=The warning is gone. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282914

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M url/url_canon_ip.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yunlian
6 years, 5 months ago (2014-07-10 17:54:31 UTC) #1
abarth-chromium
LGTM
6 years, 5 months ago (2014-07-13 23:40:37 UTC) #2
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 5 months ago (2014-07-14 01:50:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/384843002/1
6 years, 5 months ago (2014-07-14 01:51:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win8_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-14 03:37:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-14 03:44:33 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/builds/3191)
6 years, 5 months ago (2014-07-14 03:44:34 UTC) #7
yunlian
The CQ bit was checked by yunlian@chromium.org
6 years, 5 months ago (2014-07-14 05:33:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/384843002/20001
6 years, 5 months ago (2014-07-14 05:33:30 UTC) #9
commit-bot: I haz the power
Change committed as 282914
6 years, 5 months ago (2014-07-14 07:56:12 UTC) #10
Nico
Did you file a bug on gcc with a repro?
6 years, 4 months ago (2014-08-06 17:22:02 UTC) #11
chromium-reviews
6 years, 4 months ago (2014-08-06 18:04:08 UTC) #12
+1 I think it is good to file bugs for these instances. Or add the example
to a similar bug.


On Wed, Aug 6, 2014 at 10:22 AM, <thakis@chromium.org> wrote:

> Did you file a bug on gcc with a repro?
>
> https://codereview.chromium.org/384843002/
>



-- 

Luis A. Lozano | Software Engineer | llozano@google.com | +1 (408)431-5164

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698