Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 412943002: Move variations component code to variations namespace. (Closed)

Created:
6 years, 5 months ago by Alexei Svitkine (slow)
Modified:
6 years, 5 months ago
Reviewers:
Mathieu, sky, jwd, eseidel
CC:
chromium-reviews, skanuj+watch_chromium.org, tburkard+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, dominich, chromium-apps-reviews_chromium.org, gavinp+prer_chromium.org, jfweitz+watch_chromium.org, asvitkine+watch_chromium.org, Jered, davidben+watch_chromium.org, tfarina, donnd+watch_chromium.org, dominich+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Move variations component code to variations namespace. BUG=284540 TBR=sky@chromium.org, mathp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285657

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -206 lines) Patch
M chrome/browser/autocomplete/autocomplete_result_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/autocomplete/search_provider_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/bookmarks/enhanced_bookmarks_features.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_elf_init_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/metrics_private/metrics_private_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service.cc View 9 chunks +27 lines, -25 lines 0 comments Download
M chrome/browser/metrics/variations/variations_service_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 7 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/prerender/prerender_field_trial.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/variations/experiment_labels.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/common/variations/experiment_labels_unittest.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M chrome/common/variations/uniformity_field_trials.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M components/rappor/rappor_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/suggestions/suggestions_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/suggestions/suggestions_service_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/variations/android/variations_associated_data_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/processed_study.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/processed_study.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/proto/study.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/proto/variations_seed.proto View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/study_filtering.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/study_filtering.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_associated_data.h View 4 chunks +13 lines, -13 lines 0 comments Download
M components/variations/variations_associated_data.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M components/variations/variations_associated_data_unittest.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M components/variations/variations_http_header_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/variations/variations_http_header_provider.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M components/variations/variations_http_header_provider_unittest.cc View 4 chunks +6 lines, -12 lines 0 comments Download
M components/variations/variations_seed_processor.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/variations/variations_seed_simulator_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-23 19:55:17 UTC) #1
jwd
lgtm
6 years, 5 months ago (2014-07-24 20:49:06 UTC) #2
Alexei Svitkine (slow)
TBR=sky@chromium.org as chrome/ OWNER as all the non-metrics files are downstream use of the APIs ...
6 years, 5 months ago (2014-07-25 15:26:32 UTC) #3
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 5 months ago (2014-07-25 15:26:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/412943002/100001
6 years, 5 months ago (2014-07-25 15:27:55 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 15:38:54 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 15:40:37 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33349)
6 years, 5 months ago (2014-07-25 15:40:39 UTC) #8
Alexei Svitkine (slow)
TBR=mathp@ as well for suggestion component changes (which moved from chrome/ to components/ in the ...
6 years, 5 months ago (2014-07-25 17:44:13 UTC) #9
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 5 months ago (2014-07-25 17:44:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/412943002/120001
6 years, 5 months ago (2014-07-25 17:45:30 UTC) #11
Mathieu
lgtm :)
6 years, 5 months ago (2014-07-25 17:50:16 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 19:38:57 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 19:47:29 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_dbg/builds/46832)
6 years, 5 months ago (2014-07-25 19:47:31 UTC) #15
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 5 months ago (2014-07-25 19:55:41 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/412943002/120001
6 years, 5 months ago (2014-07-25 19:57:42 UTC) #17
commit-bot: I haz the power
Change committed as 285657
6 years, 5 months ago (2014-07-25 20:19:18 UTC) #18
eseidel
Broke linux compile: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux/builds/36641/steps/compile/logs/stdio FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/profile_resetter/browser.automatic_profile_resetter.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=209387 ...
6 years, 5 months ago (2014-07-25 21:15:48 UTC) #19
Alexei Svitkine (slow)
Sigh, the code was gated on official build, which apparently trybots don't test. CL updated.
6 years, 5 months ago (2014-07-25 21:25:00 UTC) #20
Alexei Svitkine (slow)
6 years, 5 months ago (2014-07-25 21:31:29 UTC) #21
Message was sent while issue was closed.
On 2014/07/25 21:25:00, Alexei Svitkine wrote:
> Sigh, the code was gated on official build, which apparently trybots don't
test.
> CL updated.

Re-land CL here: https://codereview.chromium.org/421663003

Powered by Google App Engine
This is Rietveld 408576698