Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 412843003: When overwriting a persistent handle, actually overwrite it (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

When overwriting a persistent handle, actually overwrite it BUG=390928 R=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/bindings/core/v8/V8PersistentValueMap.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-23 15:13:15 UTC) #1
haraken
LGTM Would you give me a permission to see the bug?
6 years, 5 months ago (2014-07-23 15:15:51 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-23 15:21:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/412843003/1
6 years, 5 months ago (2014-07-23 15:21:39 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:58:49 UTC) #5
Message was sent while issue was closed. 
Change committed as 178780

Powered by Google App Engine
This is Rietveld 408576698