Source/bindings/core/v8/V8PersistentValueMap.h - Issue 412843003: When overwriting a persistent handle, actually overwrite it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8PersistentValueMap.h

Issue 412843003: When overwriting a persistent handle, actually overwrite it (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8PersistentValueMap.h

diff --git a/Source/bindings/core/v8/V8PersistentValueMap.h b/Source/bindings/core/v8/V8PersistentValueMap.h

index 636da2228e2483c8c1379794066ac334e021e59a..12d9579528de9aef10b6986473970e4198d08495 100644

--- a/Source/bindings/core/v8/V8PersistentValueMap.h

+++ b/Source/bindings/core/v8/V8PersistentValueMap.h

@@ -65,7 +65,7 @@ public:

Impl* impl, KeyType key, v8::PersistentContainerValue value)

{

v8::PersistentContainerValue oldValue = Get(impl, key);

- impl->add(key, value);

+ impl->set(key, value);

return oldValue;

}

static v8::PersistentContainerValue Get(const Impl* impl, KeyType key)

« no previous file with comments | « no previous file | no next file » | no next file with comments »