[telemetry] Add util.path module and util.path.FindInstalledWindowsApplication.

[telemetry] Add util.path module and util.path.FindInstalledWindowsApplication.


BUG=336558
TEST=NO_TVCM=1 tools/telemetry/run_tests browser finder path

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285556

[tonyg, 2014-07-22 22:11:52]

lgtm

https://codereview.chromium.org/412553006/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/util/path.py (right):

https://codereview.chromium.org/412553006/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/util/path.py:23: def
FindInstalledWindowsApplication(application_path):
I think desktop_browser_backend and webdriver_desktop_browser_finder also want
to use this method.

[tonyg, 2014-07-22 22:12:57]

https://codereview.chromium.org/412553006/diff/40001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/util/path.py (right):

https://codereview.chromium.org/412553006/diff/40001/tools/telemetry/telemetr...
tools/telemetry/telemetry/util/path.py:23: def
FindInstalledWindowsApplication(application_path):
On 2014/07/22 22:11:52, tonyg wrote:
> I think desktop_browser_backend and webdriver_desktop_browser_finder also want
> to use this method.

Oh, and should we add an @test.Enabled('win') benchmark that finds notepad or
cmd or something else that we always expect to be on windows?

[dtu, 2014-07-23 22:14:50]

https://chromiumcodereview.appspot.com/412553006/diff/40001/tools/telemetry/t...
File tools/telemetry/telemetry/util/path.py (right):

https://chromiumcodereview.appspot.com/412553006/diff/40001/tools/telemetry/t...
tools/telemetry/telemetry/util/path.py:23: def
FindInstalledWindowsApplication(application_path):
On 2014/07/22 22:11:52, tonyg wrote:
> I think desktop_browser_backend and webdriver_desktop_browser_finder also want
> to use this method.

Done. Updated desktop_browser_backend. webdriver_desktop_browser_finder is a
little different, so I didn't use this, but I cleaned it up a bit.

https://chromiumcodereview.appspot.com/412553006/diff/40001/tools/telemetry/t...
tools/telemetry/telemetry/util/path.py:23: def
FindInstalledWindowsApplication(application_path):
On 2014/07/22 22:12:56, tonyg wrote:
> On 2014/07/22 22:11:52, tonyg wrote:
> > I think desktop_browser_backend and webdriver_desktop_browser_finder also
want
> > to use this method.
> 
> Oh, and should we add an @test.Enabled('win') benchmark that finds notepad or
> cmd or something else that we always expect to be on windows?

Done.

[dtu, 2014-07-23 22:14:54]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-07-23 22:16:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/412553006/60001

[commit-bot: I haz the power, 2014-07-24 02:32:16]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-24 02:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 02:46:00]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[tonyg, 2014-07-24 02:58:50]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-07-24 03:01:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/412553006/60001

[commit-bot: I haz the power, 2014-07-24 06:40:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-24 08:09:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 08:09:10]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[tonyg, 2014-07-24 13:48:54]

[ RUN ] path_unittest.PathTest.testIsExecutable Traceback (most recent call
last): run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
testMethod() testIsExecutable at
tools\telemetry\telemetry\util\path_unittest.py:15
self.assertFalse(path.IsExecutable(__file__)) assertFalse at
E:\b\depot_tools\python276_bin\lib\unittest\case.py:418 raise
self.failureException(msg) AssertionError: True is not false Locals: expr :
True msg : 'True is not false' [ FAILED ]
path_unittest.PathTest.testIsExecutable (0 ms)
On Jul 24, 2014 1:09 AM, <commit-bot@chromium.org> wrote:

> Try jobs failed on following builders:
>   win_chromium_x64_rel on tryserver.chromium
> (http://build.chromium.org/p/tryserver.chromium/builders/
> win_chromium_x64_rel/builds/33925)
>
> https://codereview.chromium.org/412553006/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dtu, 2014-07-24 18:56:15]

On 2014/07/24 13:48:54, tonyg wrote:
> [ RUN ] path_unittest.PathTest.testIsExecutable Traceback (most recent call
> last): run at E:\b\depot_tools\python276_bin\lib\unittest\case.py:331
> testMethod() testIsExecutable at
> tools\telemetry\telemetry\util\path_unittest.py:15
> self.assertFalse(path.IsExecutable(__file__)) assertFalse at
> E:\b\depot_tools\python276_bin\lib\unittest\case.py:418 raise
> self.failureException(msg) AssertionError: True is not false Locals: expr :
> True msg : 'True is not false' [ FAILED ]
> path_unittest.PathTest.testIsExecutable (0 ms)

Whoops, forgot that executable permissions are less restrictive on Windows.

[dtu, 2014-07-24 18:56:19]

The CQ bit was checked by dtu@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:58:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/412553006/80001

[commit-bot: I haz the power, 2014-07-24 23:01:59]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-25 02:28:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:28:05]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[tonyg, 2014-07-25 02:36:28]

Looks unrelated.

[tonyg, 2014-07-25 02:36:31]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-07-25 02:40:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtu@chromium.org/412553006/80001

[commit-bot: I haz the power, 2014-07-25 10:29:45]

Change committed as 285556