Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: tools/telemetry/telemetry/unittest/system_stub.py

Issue 412553006: [telemetry] Add util.path module and util.path.FindInstalledWindowsApplication. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix unit test. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/unittest/system_stub.py
diff --git a/tools/telemetry/telemetry/unittest/system_stub.py b/tools/telemetry/telemetry/unittest/system_stub.py
index 879eaf9c09a4adc68a6bb0ebdf83ec20bcd3bade..a3b50ead2ce81f8c031b976b9358c383286aff51 100644
--- a/tools/telemetry/telemetry/unittest/system_stub.py
+++ b/tools/telemetry/telemetry/unittest/system_stub.py
@@ -197,11 +197,14 @@ class OsModuleStub(object):
X_OK = os.X_OK
+ pathsep = os.pathsep
+
def __init__(self, sys_module=sys):
self.path = OsModuleStub.OsPathModuleStub(sys_module)
self.environ = OsModuleStub.OsEnvironModuleStub()
self.display = ':0'
self.local_app_data = None
+ self.sys_path = None
self.program_files = None
self.program_files_x86 = None
self.devnull = os.devnull
@@ -209,16 +212,20 @@ class OsModuleStub(object):
def access(self, path, _):
return path in self.path.files
- def getenv(self, name):
+ def getenv(self, name, value=None):
if name == 'DISPLAY':
- return self.display
+ env = self.display
elif name == 'LOCALAPPDATA':
- return self.local_app_data
+ env = self.local_app_data
+ elif name == 'PATH':
+ env = self.sys_path
elif name == 'PROGRAMFILES':
- return self.program_files
+ env = self.program_files
elif name == 'PROGRAMFILES(X86)':
- return self.program_files_x86
- raise Exception('Unsupported getenv')
+ env = self.program_files_x86
+ else:
+ raise NotImplementedError('Unsupported getenv')
+ return env if env else value
class PerfControlModuleStub(object):

Powered by Google App Engine
This is Rietveld 408576698