icu.gyp - Issue 412473002: Update Android WebView to use new system ICU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 412473002: Update Android WebView to use new system ICU (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu46.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: icu.gyp

diff --git a/icu.gyp b/icu.gyp

index 90906078ef444f8e32f057d1363a36f851ae8b00..cd5b533500f1b8c5ad2949d295712d0709570685 100644

--- a/icu.gyp

+++ b/icu.gyp

@@ -368,8 +368,8 @@

['OS=="android"', {

'direct_dependent_settings': {

'include_dirs': [

- '<(android_src)/external/icu4c/common',

- '<(android_src)/external/icu4c/i18n',

+ '<(android_src)/external/icu/source/icu4c/common',

Andrew Hayden (chromium.org) 2014/07/22 16:05:42 I think you inverted this, shouldn't it be icu/icu

hjd 2014/07/22 17:24:23 Err... yes, I don't know quite how I managed that.

+ '<(android_src)/external/icu/source/icu4c/i18n',

'link_settings': {

« no previous file with comments | « no previous file | no next file » | no next file with comments »