Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: icu.gyp

Issue 412473002: Update Android WebView to use new system ICU (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu46.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 }], 361 }],
362 ['use_system_icu==1', { 362 ['use_system_icu==1', {
363 'targets': [ 363 'targets': [
364 { 364 {
365 'target_name': 'system_icu', 365 'target_name': 'system_icu',
366 'type': 'none', 366 'type': 'none',
367 'conditions': [ 367 'conditions': [
368 ['OS=="android"', { 368 ['OS=="android"', {
369 'direct_dependent_settings': { 369 'direct_dependent_settings': {
370 'include_dirs': [ 370 'include_dirs': [
371 '<(android_src)/external/icu4c/common', 371 '<(android_src)/external/icu/source/icu4c/common',
Andrew Hayden (chromium.org) 2014/07/22 16:05:42 I think you inverted this, shouldn't it be icu/icu
hjd 2014/07/22 17:24:23 Err... yes, I don't know quite how I managed that.
372 '<(android_src)/external/icu4c/i18n', 372 '<(android_src)/external/icu/source/icu4c/i18n',
373 ], 373 ],
374 }, 374 },
375 'link_settings': { 375 'link_settings': {
376 'libraries': [ 376 'libraries': [
377 '-licui18n', 377 '-licui18n',
378 '-licuuc', 378 '-licuuc',
379 ], 379 ],
380 }, 380 },
381 }], 381 }],
382 ['OS=="qnx"', { 382 ['OS=="qnx"', {
(...skipping 212 matching lines...) Expand 10 before | Expand all | Expand 10 after
595 }, 595 },
596 'includes': [ 596 'includes': [
597 '../../build/shim_headers.gypi', 597 '../../build/shim_headers.gypi',
598 ], 598 ],
599 'toolsets': ['target'], 599 'toolsets': ['target'],
600 }, 600 },
601 ], # targets 601 ], # targets
602 }], 602 }],
603 ], # conditions 603 ], # conditions
604 } 604 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698