Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 412473002: Update Android WebView to use new system ICU (Closed)

Created:
6 years, 5 months ago by hjd
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/deps/icu46.git@master
Visibility:
Public.

Description

Update Android WebView to use new system ICU The Android WebView's use of the system ICU needs to be updated. The current copy of ICU in external/icu4c is being replaced with a copy in external/icu/icu4c/source so we need to update the include paths referenced by third_party/icu/icu.gyp. BUG=395244 R=andrewhayden@chromium.org Committed: 285202 Committed: 285220

Patch Set 1 #

Total comments: 2

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M icu.gyp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hjd
ptal, just for a sanity check :) This should only effect WebView since only WebView ...
6 years, 5 months ago (2014-07-22 13:54:52 UTC) #1
Andrew Hayden (chromium.org)
https://codereview.chromium.org/412473002/diff/1/icu.gyp File icu.gyp (right): https://codereview.chromium.org/412473002/diff/1/icu.gyp#newcode371 icu.gyp:371: '<(android_src)/external/icu/source/icu4c/common', I think you inverted this, shouldn't it be ...
6 years, 5 months ago (2014-07-22 16:05:42 UTC) #2
hjd
Thanks, that would have been bad, should not code when jet lagged. Hopefully it's right ...
6 years, 5 months ago (2014-07-22 17:24:24 UTC) #3
Andrew Hayden (chromium.org)
On 2014/07/22 17:24:24, hjd wrote: > Thanks, that would have been bad, should not code ...
6 years, 5 months ago (2014-07-22 17:26:15 UTC) #4
hjd
Committed patchset #2 manually as r285202 (presubmit successful).
6 years, 4 months ago (2014-07-24 11:56:49 UTC) #5
hjd
6 years, 4 months ago (2014-07-24 13:10:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r285220 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698