Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 4124013: autofill code review.

Created:
10 years, 1 month ago by lipalani
Modified:
7 years, 7 months ago
Reviewers:
CC:
chromium-reviews, ncarter (slow), idana, Raghu Simha, Erik does not do reviews, Nirnimesh, Aaron Boodman, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org, ben+cc_chromium.org, tim (not reviewing), dhollowa
Visibility:
Public.

Description

autofill code review. modified: AUTHORS modified: DEPS modified: LICENSE modified: PRESUBMIT.py modified: WATCHLISTS modified: base/logging.h new file: chrome/browser/sync/engine/ReadNodeMock.h modified: chrome/browser/sync/engine/syncapi.cc modified: chrome/browser/sync/engine/syncapi.h new file: chrome/browser/sync/glue/autofill_profile_change_processor.cc new file: chrome/browser/sync/glue/autofill_profile_change_processor.h new file: chrome/browser/sync/glue/autofill_profile_data_type_controller.cc new file: chrome/browser/sync/glue/autofill_profile_data_type_controller.h new file: chrome/browser/sync/glue/autofill_profile_model_associator.cc new file: chrome/browser/sync/glue/autofill_profile_model_associator.h new file: chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc modified: chrome/browser/sync/protocol/autofill_specifics.proto modified: chrome/browser/sync/syncable/model_type.cc modified: chrome/browser/sync/syncable/model_type.h modified: chrome/chrome_browser.gypi modified: chrome/chrome_tests.gypi modified: codereview.settings BUG= TEST=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30524 lines, --72 lines) Patch
AUTHORS View 0 chunks +-1 lines, --1 lines 0 comments Download
DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
PRESUBMIT.py View 0 chunks +-1 lines, --1 lines 0 comments Download
WATCHLISTS View 0 chunks +-1 lines, --1 lines 0 comments Download
base/logging.h View 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/sync/engine/ReadNodeMock.h View 1 chunk +25 lines, -0 lines 0 comments Download
chrome/browser/sync/engine/syncapi.h View 7 chunks +11 lines, -8 lines 0 comments Download
chrome/browser/sync/engine/syncapi.cc View 2 chunks +13 lines, -1 line 0 comments Download
chrome/browser/sync/glue/autofill_profile_change_processor.h View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_change_processor.cc View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_data_type_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_data_type_controller.cc View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_model_associator.h View 1 chunk +189 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_model_associator.cc View 1 chunk +308 lines, -0 lines 0 comments Download
chrome/browser/sync/glue/autofill_profile_model_associator_unittest.cc View 1 chunk +187 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/lib/protobuf_full_do_not_use.lib View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/lib/protobuf_lite.lib View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/app_specifics.pb.h View 1 chunk +160 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/app_specifics.pb.cc View 1 chunk +224 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/autofill_specifics.pb.h View 1 chunk +2635 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/autofill_specifics.pb.cc View 1 chunk +2422 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/bookmark_specifics.pb.h View 1 chunk +242 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/bookmark_specifics.pb.cc View 1 chunk +269 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/encryption.pb.h View 1 chunk +237 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/encryption.pb.cc View 1 chunk +261 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/extension_specifics.pb.h View 1 chunk +398 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/extension_specifics.pb.cc View 1 chunk +419 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/nigori_specifics.pb.h View 1 chunk +580 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/nigori_specifics.pb.cc View 1 chunk +696 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/password_specifics.pb.h View 1 chunk +741 lines, -0 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/password_specifics.pb.cc View 1 chunk +831 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/preference_specifics.pb.h View 1 chunk +242 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/preference_specifics.pb.cc View 1 chunk +269 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/session_specifics.pb.h View 1 chunk +1104 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/session_specifics.pb.cc View 1 chunk +1316 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/sync.pb.h View 1 chunk +4996 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/sync.pb.cc View 1 chunk +6433 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/test.pb.h View 1 chunk +284 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/test.pb.cc View 1 chunk +416 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/theme_specifics.pb.h View 1 chunk +344 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/theme_specifics.pb.cc View 1 chunk +377 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/typed_url_specifics.pb.h View 1 chunk +328 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/global_intermediate/protoc_out/chrome/browser/sync/protocol/typed_url_specifics.pb.cc View 1 chunk +379 lines, -0 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/BuildLog.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/descriptor.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/descriptor.pb.obj View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/descriptor_database.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/dynamic_message.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/extension_set_heavy.obj View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/generated_message_reflection.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/importer.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/message.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/parser.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/printer.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/protobuf_full_do_not_use/vc80.idb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/protobuf_full_do_not_use/vc80.pdb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/reflection_ops.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/service.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/structurally_valid.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/strutil.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/substitute.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/text_format.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/tokenizer.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/unknown_field_set.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/wire_format.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_full_do_not_use/zero_copy_stream_impl.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/BuildLog.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/coded_stream.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/common.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/extension_set.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/generated_message_util.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protobuf_lite/hash.obj View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/message_lite.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protobuf_lite/once.obj View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/protobuf_lite/vc80.idb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/protobuf_lite/vc80.pdb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/repeated_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/unknown_field_set.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/wire_format_lite.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/zero_copy_stream.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protobuf_lite/zero_copy_stream_impl_lite.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/BuildLog.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/code_generator.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/command_line_interface.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_enum.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_enum_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_extension.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_file.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protoc/cpp_generator.obj View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_helpers.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_message.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_message_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_primitive_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_service.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/cpp_string_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_enum.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_enum_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_extension.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_file.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_generator.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_helpers.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_message.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_message_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_primitive_field.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/java_service.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/main.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/mt.dep View 1 chunk +1 line, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/plugin.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/plugin.pb.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/protoc.exe.embed.manifest View 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/obj/protoc/protoc.exe.embed.manifest.res View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/protoc.exe.intermediate.manifest View 1 chunk +10 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/protoc/vc80.idb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/protoc/vc80.pdb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/python_generator.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/subprocess.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/protoc/zip_writer.obj View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/sync_proto/BuildLog.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/obj/sync_proto_cpp/BuildLog.htm View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/protoc.exe View Binary file 0 comments Download
chrome/browser/sync/protocol/Debug/protoc.ilk View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/protoc.pdb View 0 chunks +-1 lines, --1 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/app_specifics_pb2.py View 1 chunk +66 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/autofill_specifics_pb2.py View 1 chunk +451 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/bookmark_specifics_pb2.py View 1 chunk +71 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/encryption_pb2.py View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/sync/protocol/Debug/pyproto/sync_pb/extension_specifics_pb2.py View 1 chunk +99 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/nigori_specifics_pb2.py View 1 chunk +156 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/password_specifics_pb2.py View 1 chunk +177 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/preference_specifics_pb2.py View 1 chunk +71 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/session_specifics_pb2.py View 1 chunk +376 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/sync_pb2.py View 1 chunk +1394 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/test_pb2.py View 1 chunk +94 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/theme_specifics_pb2.py View 1 chunk +92 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/Debug/pyproto/sync_pb/typed_url_specifics_pb2.py View 1 chunk +92 lines, -0 lines 0 comments Download
chrome/browser/sync/protocol/autofill_specifics.proto View 2 chunks +27 lines, -0 lines 0 comments Download
chrome/browser/sync/syncable/model_type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/model_type.cc View 1 chunk +3 lines, -0 lines 0 comments Download
chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
chrome/chrome_tests.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/testserver.log View 0 chunks +-1 lines, --1 lines 0 comments Download
codereview.settings View 0 chunks +-1 lines, --1 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698