Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: chrome/browser/sync/engine/syncapi.cc

Issue 4124013: autofill code review. Base URL: http://git.chromium.org/git/chromium.git
Patch Set: Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/syncapi.h ('k') | chrome/browser/sync/glue/autofill_profile_change_processor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/syncapi.cc
diff --git a/chrome/browser/sync/engine/syncapi.cc b/chrome/browser/sync/engine/syncapi.cc
index 7bc7e7e52b33a01f3450fb58e527a699a9ff7f67..cbfb91236af31a741a846964f5929136c2e7c062 100644
--- a/chrome/browser/sync/engine/syncapi.cc
+++ b/chrome/browser/sync/engine/syncapi.cc
@@ -277,6 +277,11 @@ const sync_pb::AutofillSpecifics& BaseNode::GetAutofillSpecifics() const {
return GetEntry()->Get(SPECIFICS).GetExtension(sync_pb::autofill);
}
+const sync_pb::AutofillProfile2Specifics& BaseNode::GetAutofillProfileSpecifics() const {
+ DCHECK(GetModelType() == syncable::AUTOFILL);
+ return GetEntry()->Get(SPECIFICS).GetExtension(sync_pb::autofill_profile);
+}
+
const sync_pb::BookmarkSpecifics& BaseNode::GetBookmarkSpecifics() const {
DCHECK(GetModelType() == syncable::BOOKMARKS);
return GetEntry()->Get(SPECIFICS).GetExtension(sync_pb::bookmark);
@@ -754,7 +759,14 @@ ReadNode::ReadNode(const BaseTransaction* transaction)
}
ReadNode::~ReadNode() {
- delete entry_;
+ Reset();
+}
+
+void ReadNode::Reset()
+{
+ // [TODO] : lipalani add a comment and make this function go in base class as well.
+ delete entry_;
+ //fpassword_data_.reset();
}
void ReadNode::InitByRootLookup() {
« no previous file with comments | « chrome/browser/sync/engine/syncapi.h ('k') | chrome/browser/sync/glue/autofill_profile_change_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698