Issue 412353003: Remove convertToSkiaFilterLevel()

Issue 412353003: Remove convertToSkiaFilterLevel() (Closed)

Created:
6 years, 5 months ago by hj.r.chung

Modified:
6 years, 4 months ago

Reviewers:
f(malita)

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove convertToSkiaFilterLevel() Of the 2 callers one doesn't really need the conversion and the other can get the same results with a local flag. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178987

Patch Set 1 : #

Total comments: 4

Patch Set 2 : also removed function from header file #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -21 lines)			Patch
M	Source/platform/graphics/GraphicsContext.cpp	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/platform/graphics/skia/NativeImageSkia.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/platform/graphics/skia/SkiaUtils.h	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	Source/platform/graphics/skia/SkiaUtils.cpp	View		1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

f(malita)

LGTM + nits https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/NativeImageSkia.cpp File Source/platform/graphics/skia/NativeImageSkia.cpp (right): https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/NativeImageSkia.cpp#newcode265 Source/platform/graphics/skia/NativeImageSkia.cpp:265: bool isResampled = false; Instead of ...

6 years, 4 months ago (2014-07-25 15:06:37 UTC) #2

f(malita)

https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/NativeImageSkia.cpp File Source/platform/graphics/skia/NativeImageSkia.cpp (right): https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/NativeImageSkia.cpp#newcode264 Source/platform/graphics/skia/NativeImageSkia.cpp:264: bool useBicubicFilter = resampling == InterpolationHigh && isLazyDecoded; I ...

6 years, 4 months ago (2014-07-25 15:20:03 UTC) #3

hj.r.chung

thank you for the reviews! https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/SkiaUtils.cpp File Source/platform/graphics/skia/SkiaUtils.cpp (left): https://codereview.chromium.org/412353003/diff/20001/Source/platform/graphics/skia/SkiaUtils.cpp#oldcode202 Source/platform/graphics/skia/SkiaUtils.cpp:202: SkPaint::FilterLevel convertToSkiaFilterLevel(bool useBicubicFilter, InterpolationQuality ...

6 years, 4 months ago (2014-07-26 14:22:51 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/heejin.r.chung@samsung.com/412353003/40001

6 years, 4 months ago (2014-07-26 14:25:28 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...

6 years, 4 months ago (2014-07-26 15:26:52 UTC) #7

Message was sent while issue was closed.

Change committed as 178987

Expand Messages | Collapse Messages