Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 412303002: Use WebHistoryItem.frameSequenceNumber() to find frames for history navigations (Closed)

Created:
6 years, 5 months ago by Nate Chapin
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Use WebHistoryItem.frameSequenceNumber() to find frames for history navigations BUG=393227, 395097 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -7 lines) Patch
M content/common/page_state_serialization.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/page_state_serialization.cc View 5 chunks +7 lines, -1 line 0 comments Download
M content/common/page_state_serialization_unittest.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/history_entry.cc View 5 chunks +28 lines, -6 lines 0 comments Download
M content/renderer/history_serialization.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A content/test/data/page_state/serialized_v20.dat View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
darin (slow to review)
LGTM
6 years, 5 months ago (2014-07-25 04:39:11 UTC) #1
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 4 months ago (2014-07-28 17:17:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/412303002/1
6 years, 4 months ago (2014-07-28 17:18:56 UTC) #3
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 20:44:11 UTC) #4
Message was sent while issue was closed.
Change committed as 285969

Powered by Google App Engine
This is Rietveld 408576698