Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 412263004: Remove GN test from bots. (Closed)

Created:
6 years, 5 months ago by brettw
Modified:
6 years, 4 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Remove GN test from bots. This is causing mysterious output failures on the bots TBR=phajdan.jr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285388

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M testing/buildbot/chromium.linux.json View 5 chunks +0 lines, -5 lines 0 comments Download
M testing/buildbot/chromium_trybot.json View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
brettw
The failures look like this: http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/54217 Do you know what could be causing this? gn_unittests ...
6 years, 5 months ago (2014-07-24 22:08:35 UTC) #1
brettw
Committed patchset #1 manually as r285388 (presubmit successful).
6 years, 5 months ago (2014-07-24 22:16:25 UTC) #2
Paweł Hajdan Jr.
LGTM I think https://codereview.chromium.org/318543002 is what broke it. Please let me know if you have ...
6 years, 4 months ago (2014-07-28 14:40:28 UTC) #3
brettw
So is there no way to run a single-process test on the bots? This test ...
6 years, 4 months ago (2014-07-28 17:05:23 UTC) #4
Paweł Hajdan Jr.
6 years, 4 months ago (2014-08-11 11:17:08 UTC) #5
Message was sent while issue was closed.
On 2014/07/28 17:05:23, brettw wrote:
> So is there no way to run a single-process test on the bots? This test is
slower
> to run multiprocess and the test output is ugly, so I much prefer single
> process.

We can discuss the specific issues - I'm really not sure how to respond to it.

There were several threads about the new test launcher on chromium-dev (since
late 2013) and I don't remember a single complaint about the output being
"ugly".

I'm still open to further improvements to the test launcher. It seems to me
"ugly" output isn't necessarily enough reason not to run the test at all,
especially that *all* other gtest-based tests use it and the changes were
announced and discussed before they were deployed.

Powered by Google App Engine
This is Rietveld 408576698