Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 318543002: Make GN unit tests single process. (Closed)

Created:
6 years, 6 months ago by brettw
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Make GN unit tests single process. Clean up gin run all unittests file. I noticed some extra includes while searching for some code to copy. BUG= R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274850

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M gin/test/run_all_unittests.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gn/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M tools/gn/gn.gyp View 2 chunks +1 line, -1 line 0 comments Download
A + tools/gn/run_all_unittests.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
6 years, 6 months ago (2014-06-04 00:25:15 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 6 months ago (2014-06-04 08:08:29 UTC) #2
brettw
6 years, 6 months ago (2014-06-04 16:59:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r274850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698