Oilpan: fix reported unit test leaks.

Oilpan: fix reported unit test leaks.

Make some unit tests not rely on any external code triggering a GC to
tidy up the resources they allocate on the heap. Prevents reporting of
leaked test objects.

R=haraken@chromium.org
BUG=
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178830

[haraken, 2014-07-24 09:31:07]

Thanks for fixing this, LGTM!

[sof, 2014-07-24 09:36:48]

Please take a look.

This change in behavior is something that r178798 brought about
(https://codereview.chromium.org/412683003).

Somewhat expensive, but it tidies up.

[sof, 2014-07-24 09:39:07]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2014-07-24 09:39:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sigbjornf@opera.com/412173002/1

[commit-bot: I haz the power, 2014-07-24 09:39:57]

Change committed as 178830

[dcheng, 2014-07-24 17:35:53]

On 2014/07/24 at 09:39:57, commit-bot wrote:
> Change committed as 178830

What was the change in behavior? How did external code trigger the GC? I don't
fully see the connection.

Also, why can't we just call Heap::collectAllGarbage at the end of runHelper()?

[dcheng, 2014-07-24 17:42:00]

On 2014/07/24 at 17:35:53, dcheng (OOO wrote:
> On 2014/07/24 at 09:39:57, commit-bot wrote:
> > Change committed as 178830
> 
> What was the change in behavior? How did external code trigger the GC? I don't
fully see the connection.
> 
> Also, why can't we just call Heap::collectAllGarbage at the end of
runHelper()?

(Also, I'm happy to make the followup changes, but if someone could give me
instructions on how to test this/verify I didn't regress anything, that'd be
great =)

[haraken, 2014-07-25 00:54:43]

> > What was the change in behavior? How did external code trigger the GC? I
don't
> fully see the connection.

External code can trigger a GC when it allocates an object on oilpan's heap.
That is very undeterministic. In order to make sure that all garbage is
collected at the end of a test, we need to explicitly trigger a GC at the end of
the test.

> > Also, why can't we just call Heap::collectAllGarbage at the end of
> runHelper()?

Where is the runHelper()? If it's a method always executed at the end of various
tests, it's definitely better to put Heap::collectAllGarbage into runHelper().

[tyoshino (SeeGerritForStatus), 2014-07-25 03:41:42]

lgtm

On 2014/07/25 00:54:43, haraken wrote:
> > > What was the change in behavior? How did external code trigger the GC? I
> don't
> > fully see the connection.
> 
> External code can trigger a GC when it allocates an object on oilpan's heap.
> That is very undeterministic. In order to make sure that all garbage is
> collected at the end of a test, we need to explicitly trigger a GC at the end
of
> the test.
> 
> > > Also, why can't we just call Heap::collectAllGarbage at the end of
> > runHelper()?
> 
> Where is the runHelper()? If it's a method always executed at the end of
various
> tests, it's definitely better to put Heap::collectAllGarbage into runHelper().

FYI, yhirano@ is proposing addition of a helper for this.
https://codereview.chromium.org/407453002/diff/90001/Source/platform/testing/...

[dcheng, 2014-07-25 23:29:08]

On 2014/07/25 at 03:41:42, tyoshino wrote:
> lgtm
> 
> On 2014/07/25 00:54:43, haraken wrote:
> > > > What was the change in behavior? How did external code trigger the GC? I
> > don't
> > > fully see the connection.
> > 
> > External code can trigger a GC when it allocates an object on oilpan's heap.
> > That is very undeterministic. In order to make sure that all garbage is
> > collected at the end of a test, we need to explicitly trigger a GC at the
end of
> > the test.
> > 
> > > > Also, why can't we just call Heap::collectAllGarbage at the end of
> > > runHelper()?
> > 
> > Where is the runHelper()? If it's a method always executed at the end of
various
> > tests, it's definitely better to put Heap::collectAllGarbage into
runHelper().
> 
> FYI, yhirano@ is proposing addition of a helper for this.
>
https://codereview.chromium.org/407453002/diff/90001/Source/platform/testing/...

runHelper() is a small wrapper around the test launcher. It doesn't run at the
end of each test, but it runs right before we exit the test launcher completely:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...