Issue 412683003: Switch webkit_unit_tests to use the new test launcher.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412683003: Switch webkit_unit_tests to use the new test launcher. (Closed)

Created:
6 years, 5 months ago by dcheng

Modified:
6 years, 5 months ago

Reviewers:
eseidel, Paweł Hajdan Jr.

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -61 lines)			Patch
M	Source/web/BUILD.gn	View	1 2 3	1 chunk	+1 line, -3 lines	0 comments	Download
M	Source/web/tests/RunAllTests.cpp	View	1 2	1 chunk	+15 lines, -22 lines	0 comments	Download
M	Source/web/tests/WebUnitTests.h	View	1 2	1 chunk	+16 lines, -15 lines	0 comments	Download
M	Source/web/tests/WebUnitTests.cpp	View	1	1 chunk	+13 lines, -12 lines	0 comments	Download
M	Source/web/web.gyp	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/web/web.gypi	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/web/web_tests.gyp	View	1 2 3	1 chunk	+1 line, -5 lines	0 comments	Download

Total messages: 6 (0 generated)

dcheng

Like any good CS problem, the solution was more indirection.

6 years, 5 months ago (2014-07-23 05:00:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/412683003/60001

6 years, 5 months ago (2014-07-23 18:33:23 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...

6 years, 5 months ago (2014-07-23 23:29:57 UTC) #5

dcheng

6 years, 5 months ago (2014-07-24 01:19:35 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r178798 (presubmit successful).