Moved data reduction proxy initialization logic to ProfileImplIOData

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

Index: components/data_reduction_proxy/browser/data_reduction_proxy_params.h
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
index fbcc394d0358b2bfa1e93a44a4f1be4e452c97c1..cc14461d845b572c09efe5a562c0b14bb50017a4 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params.h
@@ -78,6 +78,8 @@ class DataReductionProxyParams {
 
   DataReductionProxyParams(int flags);

[willchan no longer on Chromium, 2014/07/29 00:26:56]

This should be explicit.

[bengr, 2014/07/29 21:29:53]

Done.

 
+  DataReductionProxyParams(const DataReductionProxyParams& params);

[willchan no longer on Chromium, 2014/07/29 00:26:57]

What makes this necessary? We generally avoid copy constructors.

[bengr, 2014/07/29 21:29:52]

I can remove this, but I think it would require having DataReductionProxyParams
support WeakPtrs, passing WeakPtrs all over the place in Profile*, and passing
ownership of DRPParams object from the DataReductionProxyChromeSettings object
to ProfileImplIOData so it is still around after DRPSettings is destroyed.

A copy constructor was much simpler.

Let me know what you think I should do.

[willchan no longer on Chromium, 2014/07/31 22:31:34]

We chatted offline about this. The style guide prohibits copy constructors in
general, and suggests using a Clone() method instead. But long-term, this code
maybe should get refactored to just be a struct, since it's just packaging data
anyway.

+
   virtual ~DataReductionProxyParams();
 
   // Returns true if a data reduction proxy was used for the given |request|.
@@ -219,8 +221,6 @@ class DataReductionProxyParams {
   bool holdback_;
 
   bool configured_on_command_line_;
-
-  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyParams);
 };
 
 }  // namespace data_reduction_proxy