Moved data reduction proxy initialization logic to ProfileImplIOData

components/data_reduction_proxy/browser/data_reduction_proxy_params.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
 #define COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 58 matching lines @@
   // bypassed or disabled. If |kAlternativeAllowed| then an alternative proxy
   // configuration is allowed to be used. This alternative configuration would
   // replace the primary and fallback proxy configurations if enabled. Finally
   // if |kPromoAllowed|, the client may show a promotion for the data reduction
   // proxy.
   //
   // A standard configuration has a primary proxy, and a fallback proxy for
   // HTTP traffic. The alternative configuration has a different primary and
   // fallback proxy for HTTP traffic, and an SSL proxy.
 
   DataReductionProxyParams(int flags);

[willchan no longer on Chromium, 2014/07/29 00:26:56]

This should be explicit.

[bengr, 2014/07/29 21:29:53]

Done.

 
+  DataReductionProxyParams(const DataReductionProxyParams& params);

[willchan no longer on Chromium, 2014/07/29 00:26:57]

What makes this necessary? We generally avoid copy constructors.

[bengr, 2014/07/29 21:29:52]

I can remove this, but I think it would require having DataReductionProxyParams
support WeakPtrs, passing WeakPtrs all over the place in Profile*, and passing
ownership of DRPParams object from the DataReductionProxyChromeSettings object
to ProfileImplIOData so it is still around after DRPSettings is destroyed.

A copy constructor was much simpler.

Let me know what you think I should do.

[willchan no longer on Chromium, 2014/07/31 22:31:34]

We chatted offline about this. The style guide prohibits copy constructors in
general, and suggests using a Clone() method instead. But long-term, this code
maybe should get refactored to just be a struct, since it's just packaging data
anyway.

+
   virtual ~DataReductionProxyParams();
 
   // Returns true if a data reduction proxy was used for the given |request|.
   // If true, |proxy_servers.first| will contain the name of the proxy that was
   // used. |proxy_servers.second| will contain the name of the data reduction
   // proxy server that would be used if |proxy_server.first| is bypassed, if one
   // exists. |proxy_servers| can be NULL if the caller isn't interested in its
   // values.
   virtual bool WasDataReductionProxyUsed(
       const net::URLRequest* request,
@@ skipping 121 matching lines @@
   GURL probe_url_;
   GURL warmup_url_;
 
   bool allowed_;
   const bool fallback_allowed_;
   bool alt_allowed_;
   const bool promo_allowed_;
   bool holdback_;
 
   bool configured_on_command_line_;
-
-  DISALLOW_COPY_AND_ASSIGN(DataReductionProxyParams);
 };
 
 }  // namespace data_reduction_proxy
 #endif  // COMPONENTS_DATA_REDUCTION_PROXY_BROWSER_DATA_REDUCTION_PROXY_PARAMS_H_