Moved data reduction proxy initialization logic to ProfileImplIOData

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc

Index: chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc
diff --git a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc
index cf8ed375a02d29f3c6bdedb9d4ec71275d10865f..57c356c1a59c2e6d7f9508ad37d5ab84322f663a 100644
--- a/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc
+++ b/chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc
@@ -7,7 +7,6 @@
 #include "base/bind.h"
 #include "base/memory/singleton.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
-#include "chrome/browser/profiles/profile.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
@@ -53,7 +52,6 @@ DataReductionProxyChromeSettingsFactory::
 
 KeyedService* DataReductionProxyChromeSettingsFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
-  Profile* profile = static_cast<Profile*>(context);
   int flags = DataReductionProxyParams::kFallbackAllowed;
   if (DataReductionProxyParams::IsIncludedInFieldTrial())
     flags |= DataReductionProxyParams::kAllowed;
@@ -67,8 +65,5 @@ KeyedService* DataReductionProxyChromeSettingsFactory::BuildServiceInstanceFor(
   DataReductionProxyParams* params = new DataReductionProxyParams(flags);
 
   // Takes ownership of params.

[willchan no longer on Chromium, 2014/07/29 00:26:56]

You don't have to fix this, but you could get rid of this documentation and use
scoped_ptr<T>::Pass() to explicitly pass ownership instead.

[bengr, 2014/07/29 21:29:52]

I won't fix this in this CL, but I tightened the code up a bit to be
a little less error prone.

-  DataReductionProxyChromeSettings* settings =
-      new DataReductionProxyChromeSettings(params);
-  settings->InitDataReductionProxySettings(profile);
-  return settings;
+  return new DataReductionProxyChromeSettings(params);
 }