Moved data reduction proxy initialization logic to ProfileImplIOData

chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings_factory.h"
 
 #include "base/bind.h"
 #include "base/memory/singleton.h"
 #include "chrome/browser/net/spdyproxy/data_reduction_proxy_chrome_settings.h"
-#include "chrome/browser/profiles/profile.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_params.h"
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_usage_stats.h"
 #include "components/keyed_service/content/browser_context_dependency_manager.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 #include "content/public/browser/browser_thread.h"
 
 using content::BrowserThread;
 using data_reduction_proxy::DataReductionProxyParams;
 using data_reduction_proxy::DataReductionProxyUsageStats;
 
@@ skipping 25 matching lines @@
         "DataReductionProxyChromeSettings",
         BrowserContextDependencyManager::GetInstance()) {
 }
 
 DataReductionProxyChromeSettingsFactory::
     ~DataReductionProxyChromeSettingsFactory() {
 }
 
 KeyedService* DataReductionProxyChromeSettingsFactory::BuildServiceInstanceFor(
     content::BrowserContext* context) const {
-  Profile* profile = static_cast<Profile*>(context);
   int flags = DataReductionProxyParams::kFallbackAllowed;
   if (DataReductionProxyParams::IsIncludedInFieldTrial())
     flags |= DataReductionProxyParams::kAllowed;
   if (DataReductionProxyParams::IsIncludedInAlternativeFieldTrial())
     flags |= DataReductionProxyParams::kAlternativeAllowed;
   if (DataReductionProxyParams::IsIncludedInPromoFieldTrial())
     flags |= DataReductionProxyParams::kPromoAllowed;
   if (DataReductionProxyParams::IsIncludedInHoldbackFieldTrial())
     flags |= DataReductionProxyParams::kHoldback;
 
   DataReductionProxyParams* params = new DataReductionProxyParams(flags);
 
   // Takes ownership of params.

[willchan no longer on Chromium, 2014/07/29 00:26:56]

You don't have to fix this, but you could get rid of this documentation and use
scoped_ptr<T>::Pass() to explicitly pass ownership instead.

[bengr, 2014/07/29 21:29:52]

I won't fix this in this CL, but I tightened the code up a bit to be
a little less error prone.

-  DataReductionProxyChromeSettings* settings =
-      new DataReductionProxyChromeSettings(params);
-  settings->InitDataReductionProxySettings(profile);
-  return settings;
+  return new DataReductionProxyChromeSettings(params);
 }