Issue 412123002: Rename WebAnimation to WebCompositorAnimation

Issue 412123002: Rename WebAnimation to WebCompositorAnimation (Closed)

Created:
6 years, 5 months ago by samli

Modified:
6 years, 4 months ago

Reviewers:
Ian Vollick, jochen (gone - plz use gerrit)

CC:
abarth-chromium, darktears, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, Rik, danakj, dglazkov+blink, krit, dstockwell, Eric Willigers, jamesr, jbroman, Mike Lawther (Google), pdr., rjwright, rwlbuis, Stephen Chennney, shans, Steve Block, Timothy Loh

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Rename WebAnimation to WebCompositorAnimation Change WebAnimation to WebCompositorAnimation Change WebAnimationCurve to WebCompositorAnimationCurve Change WebAnimationDelegate to WebCompositorAnimationDelegate This is patch 3 of 3. It builds on http://crrev.com/413983002 BUG=396358 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179910 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180514

Patch Set 1 #

Total comments: 8

Patch Set 2 : Review changes - Remove redundant macros #

Patch Set 3 : Set upstream branch #

Total comments: 14

Patch Set 4 : Review changes #

Patch Set 5 : Fix Windows build #

Patch Set 6 : Rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+241 lines, -344 lines)			Patch
M	Source/core/animation/AnimationTranslationUtilTest.cpp	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/CompositorAnimations.cpp	View	1 2 3	9 chunks	+30 lines, -30 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsImpl.h	View	1 2 3	2 chunks	+5 lines, -3 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsTest.cpp	View	1 2 3	19 chunks	+57 lines, -57 lines	0 comments	Download
M	Source/core/animation/CompositorAnimationsTestHelper.h	View	1 2 3	4 chunks	+22 lines, -22 lines	0 comments	Download
M	Source/platform/graphics/GraphicsLayer.h	View	1 2 3 4 5	5 chunks	+7 lines, -7 lines	0 comments	Download
M	Source/platform/graphics/GraphicsLayer.cpp	View	1 2 3 4 5	4 chunks	+11 lines, -5 lines	0 comments	Download
M	Source/platform/graphics/GraphicsLayerTest.cpp	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/scroll/ProgrammaticScrollAnimator.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/LinkHighlight.h	View	1 2 3 4 5	3 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/web/LinkHighlight.cpp	View	1 2 3 4 5	3 chunks	+5 lines, -5 lines	0 comments	Download
D	public/platform/WebAnimation.h	View	1 2	1 chunk	+0 lines, -82 lines	0 comments	Download
D	public/platform/WebAnimationCurve.h	View	1 2	1 chunk	+0 lines, -60 lines	0 comments	Download
D	public/platform/WebAnimationDelegate.h	View	1 2	1 chunk	+0 lines, -43 lines	0 comments	Download
M	public/platform/WebCompositorAnimation.h	View	1 2 3	1 chunk	+37 lines, -1 line	0 comments	Download
M	public/platform/WebCompositorAnimationCurve.h	View	1 2 3	1 chunk	+27 lines, -1 line	0 comments	Download
M	public/platform/WebCompositorAnimationDelegate.h	View	1 2 3 4	1 chunk	+16 lines, -2 lines	0 comments	Download
M	public/platform/WebCompositorSupport.h	View	1 2 3 4 5	3 chunks	+4 lines, -4 lines	0 comments	Download
M	public/platform/WebFilterAnimationCurve.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	public/platform/WebFloatAnimationCurve.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	public/platform/WebLayer.h	View	1 2 3 4 5	3 chunks	+5 lines, -6 lines	0 comments	Download
M	public/platform/WebScrollOffsetAnimationCurve.h	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	public/platform/WebTransformAnimationCurve.h	View	1 2 3 4 5	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 24 (0 generated)

Expand Messages | Collapse Messages

Ian Vollick

lgtm with nits. https://codereview.chromium.org/412123002/diff/1/public/platform/WebCompositorAnimation.h File public/platform/WebCompositorAnimation.h (right): https://codereview.chromium.org/412123002/diff/1/public/platform/WebCompositorAnimation.h#newcode16 public/platform/WebCompositorAnimation.h:16: #define WebCompositorAnimation WebCompositorAnimation Delete this, pls. ...

6 years, 5 months ago (2014-07-24 13:23:35 UTC) #2

samli

Added review changes. Still need OWNERs approval https://codereview.chromium.org/412123002/diff/1/public/platform/WebCompositorAnimation.h File public/platform/WebCompositorAnimation.h (right): https://codereview.chromium.org/412123002/diff/1/public/platform/WebCompositorAnimation.h#newcode16 public/platform/WebCompositorAnimation.h:16: #define WebCompositorAnimation ...

6 years, 5 months ago (2014-07-25 01:34:33 UTC) #3

samli

+jochen Need OWNERs approval for Source/web and public/platform

6 years, 4 months ago (2014-08-04 07:10:33 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/412123002/40001

6 years, 4 months ago (2014-08-04 08:31:51 UTC) #7

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...

6 years, 4 months ago (2014-08-04 08:58:44 UTC) #8

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 4 months ago (2014-08-04 09:02:16 UTC) #9

commit-bot: I haz the power

Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/18254)

6 years, 4 months ago (2014-08-04 09:02:17 UTC) #10

jochen (gone - plz use gerrit)

please my drafts I forgot to publish :-/ https://codereview.chromium.org/412123002/diff/40001/public/platform/WebCompositorAnimation.h File public/platform/WebCompositorAnimation.h (right): https://codereview.chromium.org/412123002/diff/40001/public/platform/WebCompositorAnimation.h#newcode9 public/platform/WebCompositorAnimation.h:9: #include ...

6 years, 4 months ago (2014-08-04 09:07:34 UTC) #11

samli

Incorporates review changes. Also removes usage of blink:: in places it touches. https://codereview.chromium.org/412123002/diff/40001/public/platform/WebCompositorAnimation.h File public/platform/WebCompositorAnimation.h ...

6 years, 4 months ago (2014-08-11 04:10:59 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/412123002/80001

6 years, 4 months ago (2014-08-11 07:00:27 UTC) #14

samli

A revert of this CL (patchset #5) has been created in https://codereview.chromium.org/470443002/ by samli@chromium.org. The ...

6 years, 4 months ago (2014-08-13 01:49:58 UTC) #16

alancutter (OOO until 2018)

On 2014/08/13 01:49:58, samli wrote: > A revert of this CL (patchset #5) has been ...

6 years, 4 months ago (2014-08-13 07:00:55 UTC) #17

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/412123002/80001

6 years, 4 months ago (2014-08-19 01:04:52 UTC) #19

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 4 months ago (2014-08-19 01:05:20 UTC) #20

commit-bot: I haz the power

Failed to apply patch for Source/platform/graphics/GraphicsLayer.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...

6 years, 4 months ago (2014-08-19 01:05:21 UTC) #21

Failed to apply patch for Source/platform/graphics/GraphicsLayer.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/graphics/GraphicsLayer.cpp
  Hunk #2 FAILED at 59.
  Hunk #3 succeeded at 946 (offset -6 lines).
  Hunk #4 succeeded at 1027 (offset -6 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
Source/platform/graphics/GraphicsLayer.cpp.rej

Patch:       Source/platform/graphics/GraphicsLayer.cpp
Index: Source/platform/graphics/GraphicsLayer.cpp
diff --git a/Source/platform/graphics/GraphicsLayer.cpp
b/Source/platform/graphics/GraphicsLayer.cpp
index
2adb26d6a3579e12040413890df180bf4d98a20d..a475db489616b8a552dfeb6385ddaae5d1874c51
100644
--- a/Source/platform/graphics/GraphicsLayer.cpp
+++ b/Source/platform/graphics/GraphicsLayer.cpp
@@ -38,7 +38,7 @@
 #include "platform/scroll/ScrollableArea.h"
 #include "platform/text/TextStream.h"
 #include "public/platform/Platform.h"
-#include "public/platform/WebAnimation.h"
+#include "public/platform/WebCompositorAnimation.h"
 #include "public/platform/WebCompositorSupport.h"
 #include "public/platform/WebFilterOperations.h"
 #include "public/platform/WebFloatPoint.h"
@@ -59,7 +59,7 @@
 #endif
 
 using blink::Platform;
-using blink::WebAnimation;
+using blink::WebCompositorAnimation;
 using blink::WebFilterOperations;
 using blink::WebLayer;
 using blink::WebPoint;
@@ -952,9 +952,9 @@ void GraphicsLayer::setContentsToNinePatch(Image* image,
const IntRect& aperture
     setContentsTo(m_ninePatchLayer ? m_ninePatchLayer->layer() : 0);
 }
 
-bool GraphicsLayer::addAnimation(PassOwnPtr<WebAnimation> popAnimation)
+bool GraphicsLayer::addAnimation(PassOwnPtr<WebCompositorAnimation>
popAnimation)
 {
-    OwnPtr<WebAnimation> animation(popAnimation);
+    OwnPtr<WebCompositorAnimation> animation(popAnimation);
     ASSERT(animation);
     platformLayer()->setAnimationDelegate(this);
 
@@ -1033,13 +1033,13 @@ void GraphicsLayer::paint(GraphicsContext& context,
const IntRect& clip)
 }
 
 
-void GraphicsLayer::notifyAnimationStarted(double monotonicTime,
WebAnimation::TargetProperty)
+void GraphicsLayer::notifyAnimationStarted(double monotonicTime,
WebCompositorAnimation::TargetProperty)
 {
     if (m_client)
         m_client->notifyAnimationStarted(this, monotonicTime);
 }
 
-void GraphicsLayer::notifyAnimationFinished(double,
WebAnimation::TargetProperty)
+void GraphicsLayer::notifyAnimationFinished(double,
WebCompositorAnimation::TargetProperty)
 {
     // Do nothing.
 }

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/samli@chromium.org/412123002/100001

6 years, 4 months ago (2014-08-19 02:53:06 UTC) #23

commit-bot: I haz the power

6 years, 4 months ago (2014-08-19 02:57:02 UTC) #24

Message was sent while issue was closed.

Committed patchset #6 (100001) as 180514

Expand Messages | Collapse Messages