Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 412033004: Use Traversal<>::firstChild() instead of firstWithin() when iterating over children (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-rendering, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eric.carlson_apple.com, f(malita), fs, gasubic, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr., philipj_slow, rwlbuis, rune+blink, Stephen Chennney, sof, nessy, vcarbune.chromium, zoltan1
Project:
blink
Visibility:
Public.

Description

Use Traversal<>::firstChild() instead of firstWithin() when iterating over children Use Traversal<>::firstChild() instead of firstWithin() when iterating over children. It makes it clearer that we are only iterating over the children and not traversing the descendants. There is no behavior change since firstChild() is equivalent to firstWithin() for ElementTraversal / Traversal<HTMLElement>. However, using firstChild() improves readability a bit. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178819

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ParentNode.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTRegion.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 5 months ago (2014-07-24 02:30:25 UTC) #1
Inactive
PTAL
6 years, 5 months ago (2014-07-24 02:30:46 UTC) #2
esprehn
lgtm
6 years, 5 months ago (2014-07-24 07:19:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/412033004/1
6 years, 5 months ago (2014-07-24 07:20:49 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 07:25:14 UTC) #5
Message was sent while issue was closed.
Change committed as 178819

Powered by Google App Engine
This is Rietveld 408576698