Source/core/dom/ParentNode.h - Issue 412033004: Use Traversal<>::firstChild() instead of firstWithin() when iterating over children

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ParentNode.h

Issue 412033004: Use Traversal<>::firstChild() instead of firstWithin() when iterating over children (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ParentNode.h

diff --git a/Source/core/dom/ParentNode.h b/Source/core/dom/ParentNode.h

index db05e1dd42b139ef48a03a53721aae1ef4a0df0a..4fae173795bb3190aa3b19c787beb89fe7b96470 100644

--- a/Source/core/dom/ParentNode.h

+++ b/Source/core/dom/ParentNode.h

@@ -57,7 +57,7 @@ public:

static unsigned childElementCount(ContainerNode& node)

{

unsigned count = 0;

- for (Element* child = ElementTraversal::firstWithin(node); child; child = ElementTraversal::nextSibling(*child))

+ for (Element* child = ElementTraversal::firstChild(node); child; child = ElementTraversal::nextSibling(*child))

++count;

return count;

}

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/html/HTMLTableElement.cpp » ('j') | no next file with comments »