Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 411903002: Fixed the crash when adding a chromium sink to remote audio track or (Closed)

Created:
6 years, 5 months ago by no longer working on chromium
Modified:
6 years, 5 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fixed the crash when adding a chromium sink to remote audio track or adding a track to peerconnection more than once. NOTRY=true BUG=396447 TEST=open peerConnection demo, http://googlechrome.github.io/webrtc/samples/web/content/peerconnection/ 2. start a call 3. Open JS console and input below codes: # adding a chromium sink to remote audio track: var v = new webkitMediaStream(); v.addTrack(pc2.getRemoteStreams()[0].getAudioTracks()[0]); var a = document.createElement('audio'); a.src = URL.createObjectURL(v); # add a track to peer connection more than once: var v = new webkitMediaStream(); v.addTrack(pc2.getRemoteStreams()[0].getAudioTracks()[0]); pc1.addStream(v); Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285528

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressed the comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M content/browser/renderer_host/media/media_stream_track_metrics_host.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M content/public/renderer/media_stream_audio_sink.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
no longer working on chromium
Ronghua, could you please review this CL? I might write some browser test in another ...
6 years, 5 months ago (2014-07-23 13:57:39 UTC) #1
Ronghua Wu (Left Chromium)
https://codereview.chromium.org/411903002/diff/1/content/browser/renderer_host/media/media_stream_track_metrics_host.cc File content/browser/renderer_host/media/media_stream_track_metrics_host.cc (right): https://codereview.chromium.org/411903002/diff/1/content/browser/renderer_host/media/media_stream_track_metrics_host.cc#newcode59 content/browser/renderer_host/media/media_stream_track_metrics_host.cc:59: void MediaStreamTrackMetricsHost::OnRemoveTrack(uint64 id) { curious, when will OnAddTrack and ...
6 years, 5 months ago (2014-07-23 15:53:43 UTC) #2
no longer working on chromium
https://codereview.chromium.org/411903002/diff/1/content/browser/renderer_host/media/media_stream_track_metrics_host.cc File content/browser/renderer_host/media/media_stream_track_metrics_host.cc (right): https://codereview.chromium.org/411903002/diff/1/content/browser/renderer_host/media/media_stream_track_metrics_host.cc#newcode59 content/browser/renderer_host/media/media_stream_track_metrics_host.cc:59: void MediaStreamTrackMetricsHost::OnRemoveTrack(uint64 id) { On 2014/07/23 15:53:42, Ronghua Wu ...
6 years, 5 months ago (2014-07-24 13:23:31 UTC) #3
no longer working on chromium
Thanks Ronghua, PTAL. FYI, I will be on parental leave from Tuesday, so it will ...
6 years, 5 months ago (2014-07-24 13:24:57 UTC) #4
Ronghua Wu (Left Chromium)
LGTM Please update the cl description as chatted offline to include the adding stream to ...
6 years, 5 months ago (2014-07-24 16:03:58 UTC) #5
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-24 18:10:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/411903002/20001
6 years, 5 months ago (2014-07-24 18:11:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 19:17:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 19:23:05 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82161)
6 years, 5 months ago (2014-07-24 19:23:06 UTC) #10
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-25 08:20:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/411903002/20001
6 years, 5 months ago (2014-07-25 08:22:28 UTC) #12
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:23:55 UTC) #13
Message was sent while issue was closed.
Change committed as 285528

Powered by Google App Engine
This is Rietveld 408576698