Fixed the crash when adding a chromium sink to remote audio track or

content/public/renderer/media_stream_audio_sink.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/renderer/media_stream_audio_sink.h"
 
 #include "base/logging.h"
 #include "content/renderer/media/media_stream_track.h"
 #include "content/renderer/media/webrtc_local_audio_track.h"
 #include "third_party/WebKit/public/platform/WebMediaStreamSource.h"
 #include "third_party/WebKit/public/platform/WebMediaStreamTrack.h"
 
 namespace content {
 
 void MediaStreamAudioSink::AddToAudioTrack(
     MediaStreamAudioSink* sink,
     const blink::WebMediaStreamTrack& track) {
   DCHECK(track.source().type() == blink::WebMediaStreamSource::TypeAudio);
   MediaStreamTrack* native_track = MediaStreamTrack::GetTrack(track);
   // TODO(xians): Support remote audio track.
-  DCHECK(native_track->is_local_track());
+  if (!native_track->is_local_track()) {
+    LOG(ERROR) << "Only local audio track is supported now";

[Ronghua Wu (Left Chromium), 2014/07/23 15:53:42]

add info about what is "supported".

E.g. Can't add a remote track to a local stream.

[no longer working on chromium, 2014/07/24 13:23:31]

Done.

+    return;
+  }
+
   WebRtcLocalAudioTrack* audio_track =
       static_cast<WebRtcLocalAudioTrack*>(native_track);
   audio_track->AddSink(sink);
 }
 
 void MediaStreamAudioSink::RemoveFromAudioTrack(
     MediaStreamAudioSink* sink,
     const blink::WebMediaStreamTrack& track) {
   MediaStreamTrack* native_track = MediaStreamTrack::GetTrack(track);
   // TODO(xians): Support remote audio track.
-  DCHECK(native_track->is_local_track());
+  if (!native_track->is_local_track()) {
+    LOG(ERROR) << "Only local audio track is supported now";

[Ronghua Wu (Left Chromium), 2014/07/23 15:53:42]

dito

[no longer working on chromium, 2014/07/24 13:23:31]

Done.

+    return;
+  }
+
   WebRtcLocalAudioTrack* audio_track =
       static_cast<WebRtcLocalAudioTrack*>(native_track);
   audio_track->RemoveSink(sink);
 }
 
 }  // namespace content