Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 411833006: Use the mediaControlsButton() helper more in media tests (Closed)

Created:
6 years, 5 months ago by philipj_slow
Modified:
6 years, 5 months ago
Reviewers:
fs
CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com
Project:
blink
Visibility:
Public.

Description

Use the mediaControlsButton() helper more in media tests Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M LayoutTests/media/media-captions-no-controls.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/media/media-captions-no-controls-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/media-controls.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/media/media-controls-invalid-url.html View 1 chunk +1 line, -9 lines 0 comments Download
M LayoutTests/media/video-controls-toggling.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
STET
6 years, 5 months ago (2014-07-23 14:34:08 UTC) #1
philipj_slow
On 2014/07/23 14:34:08, philipj wrote: > STET Um, sorry, bad joke, I mean PTAL :)
6 years, 5 months ago (2014-07-23 14:35:02 UTC) #2
fs
On 2014/07/23 14:35:02, philipj wrote: > On 2014/07/23 14:34:08, philipj wrote: > > STET > ...
6 years, 5 months ago (2014-07-23 15:23:51 UTC) #3
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 5 months ago (2014-07-23 15:25:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/411833006/1
6 years, 5 months ago (2014-07-23 15:25:34 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 18:53:35 UTC) #6
Message was sent while issue was closed.
Change committed as 178777

Powered by Google App Engine
This is Rietveld 408576698