LayoutTests/media/media-controls.js - Issue 411833006: Use the mediaControlsButton() helper more in media tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/media/media-controls.js

Issue 411833006: Use the mediaControlsButton() helper more in media tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/media/media-captions-no-controls-expected.txt ('k') | LayoutTests/media/media-controls-invalid-url.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/media/media-controls.js

diff --git a/LayoutTests/media/media-controls.js b/LayoutTests/media/media-controls.js

index 6a3c87d10ca7b5c0c72935edd613c9256cd0d98d..c6767f79fb1bd49340b7797e76f6eece8df36caa 100644

--- a/LayoutTests/media/media-controls.js

+++ b/LayoutTests/media/media-controls.js

@@ -90,7 +90,7 @@ function textTrackDisplayElement(parentElement, id, cueNumber)

function testClosedCaptionsButtonVisibility(expected)

{

try {

- captionsButtonElement = mediaControlsElement(internals.shadowRoot(mediaElement).firstChild, "-webkit-media-controls-toggle-closed-captions-button");

+ captionsButtonElement = mediaControlsButton(mediaElement, "toggle-closed-captions-button");

captionsButtonCoordinates = mediaControlsButtonCoordinates(mediaElement, "toggle-closed-captions-button");

} catch (exception) {

consoleWrite("Failed to find a closed captions button or its coordinates: " + exception);

« no previous file with comments | « LayoutTests/media/media-captions-no-controls-expected.txt ('k') | LayoutTests/media/media-controls-invalid-url.html » ('j') | no next file with comments »