Issue 411833003: Add tests for gfx::ScreenRectTo/FromNSRect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 411833003: Add tests for gfx::ScreenRectTo/FromNSRect. (Closed)

Created:
6 years, 5 months ago by tapted

Modified:
6 years, 4 months ago

Reviewers:
Robert Sesek, danakj

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add tests for gfx::ScreenRectTo/FromNSRect. Tests are added for these coordinate conversion functions with various simulated screen setups. The recently moved ScopedObjCClassSwizzler in src/base/test is used so that -[NSScreen frame] can be mocked to return a known value. BUG=378134 TEST=gfx_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289929

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : gix gn #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+111 lines, -0 lines)			Patch
M	ui/gfx/BUILD.gn	View	1 2	2 chunks	+3 lines, -0 lines	0 comments	Download
M	ui/gfx/gfx_tests.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
A	ui/gfx/mac/coordinate_conversion_unittest.mm	View		1 chunk	+107 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tapted

Hi, dnakj for review/OWNERS rsesek for mac: you have already reviewed this in https://codereview.chromium.org/345243007/#ps80001 please ...

6 years, 4 months ago (2014-08-14 06:43:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/411833003/50001

6 years, 4 months ago (2014-08-15 07:50:03 UTC) #5

commit-bot: I haz the power

6 years, 4 months ago (2014-08-15 17:48:08 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (50001) as 289929

Expand Messages | Collapse Messages