Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 411683002: Remove muted_ and playback_rate_ from media::AudioRendererAlgorithm. (Closed)

Created:
6 years, 5 months ago by scherkus (not reviewing)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove muted_ and playback_rate_ from media::AudioRendererAlgorithm. We don't need to hold onto the state as playback rate is only used when calling FillBuffer(). BUG=370634 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284802

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix cast #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -83 lines) Patch
M media/cast/test/fake_media_source.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/audio_renderer_algorithm.h View 7 chunks +8 lines, -25 lines 0 comments Download
M media/filters/audio_renderer_algorithm.cc View 10 chunks +25 lines, -32 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 6 chunks +16 lines, -14 lines 0 comments Download
M media/filters/audio_renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/audio_renderer_impl.cc View 8 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
https://codereview.chromium.org/411683002/diff/40001/media/filters/audio_renderer_algorithm_unittest.cc File media/filters/audio_renderer_algorithm_unittest.cc (left): https://codereview.chromium.org/411683002/diff/40001/media/filters/audio_renderer_algorithm_unittest.cc#oldcode148 media/filters/audio_renderer_algorithm_unittest.cc:148: void CheckFakeData(AudioBus* audio_data, int frames_written) { I'm not sure ...
6 years, 5 months ago (2014-07-22 19:25:50 UTC) #1
DaleCurtis
lgtm https://codereview.chromium.org/411683002/diff/40001/media/filters/audio_renderer_algorithm_unittest.cc File media/filters/audio_renderer_algorithm_unittest.cc (left): https://codereview.chromium.org/411683002/diff/40001/media/filters/audio_renderer_algorithm_unittest.cc#oldcode148 media/filters/audio_renderer_algorithm_unittest.cc:148: void CheckFakeData(AudioBus* audio_data, int frames_written) { On 2014/07/22 ...
6 years, 5 months ago (2014-07-22 19:32:56 UTC) #2
scherkus (not reviewing)
hclam: can you look at media/cast/test/fake_media_source.cc ?
6 years, 5 months ago (2014-07-22 20:04:19 UTC) #3
Alpha Left Google
On 2014/07/22 20:04:19, scherkus wrote: > hclam: can you look at media/cast/test/fake_media_source.cc ? LGTM.
6 years, 5 months ago (2014-07-22 20:06:20 UTC) #4
scherkus (not reviewing)
The CQ bit was checked by scherkus@chromium.org
6 years, 5 months ago (2014-07-22 20:07:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/411683002/60001
6 years, 5 months ago (2014-07-22 20:09:48 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 23:27:43 UTC) #7
Message was sent while issue was closed.
Change committed as 284802

Powered by Google App Engine
This is Rietveld 408576698