Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4140)

Unified Diff: chrome/browser/download/download_permission_request.cc

Issue 411503005: Change tests to prepare for turning on the permission bubble flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_permission_request.cc
diff --git a/chrome/browser/download/download_permission_request.cc b/chrome/browser/download/download_permission_request.cc
index c8ac3db4fab19736fb7764ee3f1cf3d912008de1..df76a3773f12f4f7d9edfbf0c555a73f2c4c105d 100644
--- a/chrome/browser/download/download_permission_request.cc
+++ b/chrome/browser/download/download_permission_request.cc
@@ -28,8 +28,8 @@ base::string16 DownloadPermissionRequest::GetMessageTextFragment() const {
}
bool DownloadPermissionRequest::HasUserGesture() const {
- // TODO(gbillock): user gesture for multiple downloads is difficult to
- // propagate, and the normal thing is that it is background.
+ // Only non-gestured requests go through the path of the download request
+ // limiter, so always return false.
return false;
}

Powered by Google App Engine
This is Rietveld 408576698