Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: chrome/browser/download/download_permission_request.cc

Issue 411503005: Change tests to prepare for turning on the permission bubble flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/download/download_permission_request.h" 5 #include "chrome/browser/download/download_permission_request.h"
6 6
7 #include "chrome/grit/generated_resources.h" 7 #include "chrome/grit/generated_resources.h"
8 #include "content/public/browser/web_contents.h" 8 #include "content/public/browser/web_contents.h"
9 #include "grit/theme_resources.h" 9 #include "grit/theme_resources.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
(...skipping 10 matching lines...) Expand all
21 21
22 base::string16 DownloadPermissionRequest::GetMessageText() const { 22 base::string16 DownloadPermissionRequest::GetMessageText() const {
23 return l10n_util::GetStringUTF16(IDS_MULTI_DOWNLOAD_WARNING); 23 return l10n_util::GetStringUTF16(IDS_MULTI_DOWNLOAD_WARNING);
24 } 24 }
25 25
26 base::string16 DownloadPermissionRequest::GetMessageTextFragment() const { 26 base::string16 DownloadPermissionRequest::GetMessageTextFragment() const {
27 return l10n_util::GetStringUTF16(IDS_MULTI_DOWNLOAD_PERMISSION_FRAGMENT); 27 return l10n_util::GetStringUTF16(IDS_MULTI_DOWNLOAD_PERMISSION_FRAGMENT);
28 } 28 }
29 29
30 bool DownloadPermissionRequest::HasUserGesture() const { 30 bool DownloadPermissionRequest::HasUserGesture() const {
31 // TODO(gbillock): user gesture for multiple downloads is difficult to 31 // Only non-gestured requests go through the path of the download request
32 // propagate, and the normal thing is that it is background. 32 // limiter, so always return false.
33 return false; 33 return false;
34 } 34 }
35 35
36 GURL DownloadPermissionRequest::GetRequestingHostname() const { 36 GURL DownloadPermissionRequest::GetRequestingHostname() const {
37 const content::WebContents* web_contents = host_->web_contents(); 37 const content::WebContents* web_contents = host_->web_contents();
38 if (web_contents) { 38 if (web_contents) {
39 return web_contents->GetURL(); 39 return web_contents->GetURL();
40 } 40 }
41 return GURL(); 41 return GURL();
42 } 42 }
(...skipping 13 matching lines...) Expand all
56 } 56 }
57 57
58 void DownloadPermissionRequest::Cancelled() { 58 void DownloadPermissionRequest::Cancelled() {
59 // TODO(gbillock): There's currently no suitable method for telling the host 59 // TODO(gbillock): There's currently no suitable method for telling the host
60 // that a request is cancelled. 60 // that a request is cancelled.
61 } 61 }
62 62
63 void DownloadPermissionRequest::RequestFinished() { 63 void DownloadPermissionRequest::RequestFinished() {
64 delete this; 64 delete this;
65 } 65 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698