Source/core/dom/custom/CustomElementDefinition.h - Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/custom/CustomElementDefinition.h

Issue 41133002: Remove virtual destructors for CustomElementDefinition and CustomElementRegistry (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/custom/CustomElementDefinition.h

diff --git a/Source/core/dom/custom/CustomElementDefinition.h b/Source/core/dom/custom/CustomElementDefinition.h

index 601f671a148640fcbd75fafb7c3d95564da42b3a..5bf15a719e80042b76d77b46c1bcf30c4d13898c 100644

--- a/Source/core/dom/custom/CustomElementDefinition.h

+++ b/Source/core/dom/custom/CustomElementDefinition.h

@@ -43,8 +43,6 @@ class CustomElementDefinition : public RefCounted<CustomElementDefinition> {

public:

static PassRefPtr<CustomElementDefinition> create(const CustomElementDescriptor&, PassRefPtr<CustomElementLifecycleCallbacks>);

- virtual ~CustomElementDefinition() { }

const CustomElementDescriptor& descriptor() const { return m_descriptor; }

CustomElementLifecycleCallbacks* callbacks() const { return m_callbacks.get(); }

« no previous file with comments | « no previous file | Source/core/dom/custom/CustomElementRegistry.h » ('j') | no next file with comments »