Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 411273002: Replace further questionable HashMap::add usages in bindings (Closed)

Created:
6 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 5 months ago
Reviewers:
haraken, dcarney
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

Replace further questionable HashMap::add usages in bindings BUG=390928 R=dcarney@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/bindings/core/v8/DOMWrapperMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jochen (gone - plz use gerrit)
6 years, 5 months ago (2014-07-24 06:59:29 UTC) #1
dcarney
lgtm
6 years, 5 months ago (2014-07-24 07:00:16 UTC) #2
jochen (gone - plz use gerrit)
The CQ bit was checked by jochen@chromium.org
6 years, 5 months ago (2014-07-24 07:00:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/411273002/1
6 years, 5 months ago (2014-07-24 07:01:32 UTC) #4
haraken
LGTM
6 years, 5 months ago (2014-07-24 07:13:10 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 08:07:33 UTC) #6
Message was sent while issue was closed.
Change committed as 178823

Powered by Google App Engine
This is Rietveld 408576698