Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: Source/bindings/core/v8/DOMWrapperMap.h

Issue 411273002: Replace further questionable HashMap::add usages in bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/bindings/core/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 static Iterator End(Impl* impl) { return impl->end(); } 101 static Iterator End(Impl* impl) { return impl->end(); }
102 static v8::PersistentContainerValue Value(Iterator& iter) 102 static v8::PersistentContainerValue Value(Iterator& iter)
103 { 103 {
104 return iter->value; 104 return iter->value;
105 } 105 }
106 static KeyType* Key(Iterator& iter) { return iter->key; } 106 static KeyType* Key(Iterator& iter) { return iter->key; }
107 static v8::PersistentContainerValue Set( 107 static v8::PersistentContainerValue Set(
108 Impl* impl, KeyType* key, v8::PersistentContainerValue value) 108 Impl* impl, KeyType* key, v8::PersistentContainerValue value)
109 { 109 {
110 v8::PersistentContainerValue oldValue = Get(impl, key); 110 v8::PersistentContainerValue oldValue = Get(impl, key);
111 impl->add(key, value); 111 impl->set(key, value);
112 return oldValue; 112 return oldValue;
113 } 113 }
114 static v8::PersistentContainerValue Get(const Impl* impl, KeyType* key) 114 static v8::PersistentContainerValue Get(const Impl* impl, KeyType* key)
115 { 115 {
116 return impl->get(key); 116 return impl->get(key);
117 } 117 }
118 118
119 static v8::PersistentContainerValue Remove(Impl* impl, KeyType* key) 119 static v8::PersistentContainerValue Remove(Impl* impl, KeyType* key)
120 { 120 {
121 return impl->take(key); 121 return impl->take(key);
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 void* key) 162 void* key)
163 { 163 {
164 ScriptForbiddenScope forbiddenScope; 164 ScriptForbiddenScope forbiddenScope;
165 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095. 165 RELEASE_ASSERT(!value.IsEmpty()); // See crbug.com/368095.
166 releaseObject(v8::Local<v8::Object>::New(isolate, value)); 166 releaseObject(v8::Local<v8::Object>::New(isolate, value));
167 } 167 }
168 168
169 } // namespace blink 169 } // namespace blink
170 170
171 #endif // DOMWrapperMap_h 171 #endif // DOMWrapperMap_h
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/core/v8/SerializedScriptValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698