Remove use of innerHTML and Toolstrips from example extensions

Remove use of innerHTML and Toolstrips from example extensions

BUG=27860, 27861
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32674

[rafaelw, 2009-11-20 04:26:20]

Note that I removed tutorials/debugging which appears to be the old toolstrip
version of tutorials/getstarted (for which the docs have already been upgraded).

[Erik does not do reviews, 2009-11-20 16:51:49]

Four files appear to be missing from Rietveld altogether (the ones without a
letter on the left side).  Re-upload?

http://codereview.chromium.org/411008/diff/1009/1014
File chrome/common/extensions/docs/examples/api/messaging/timer/popup.html
(right):

http://codereview.chromium.org/411008/diff/1009/1014#newcode16
Line 16: elm.removeChild(elm.firstChild)
missing ;
JS style is to always use {} (partly to catch these types of errors)

http://codereview.chromium.org/411008/diff/1009/1014#newcode17
Line 17: elm.appendChild(document.createTextNode(text));
You should just use innerText here. (and you can get rid of the remove child
above).  You use this pattern throughout your change, so I'll just note it here
rather than at each point.

http://codereview.chromium.org/411008/diff/1009/1016
File chrome/common/extensions/docs/examples/extensions/buildbot/popup.html
(right):

http://codereview.chromium.org/411008/diff/1009/1016#newcode45
Line 45: anchor.onclick = showConsole;
What do you think about using addListener("click") as a better style example?

http://codereview.chromium.org/411008/diff/1009/1016#newcode47
Line 47: anchor.appendChild(document.createTextNode("The tree is completely
green."));
nit: 80 cols

[rafaelw, 2009-11-20 20:11:57]

http://codereview.chromium.org/411008/diff/1009/1014
File chrome/common/extensions/docs/examples/api/messaging/timer/popup.html
(right):

http://codereview.chromium.org/411008/diff/1009/1014#newcode16
Line 16: elm.removeChild(elm.firstChild)
On 2009/11/20 16:51:49, Erik Kay wrote:
> missing ;
> JS style is to always use {} (partly to catch these types of errors)

Done.

http://codereview.chromium.org/411008/diff/1009/1014#newcode17
Line 17: elm.appendChild(document.createTextNode(text));
On 2009/11/20 16:51:49, Erik Kay wrote:
> You should just use innerText here. (and you can get rid of the remove child
> above).  You use this pattern throughout your change, so I'll just note it
here
> rather than at each point.

Done.

http://codereview.chromium.org/411008/diff/1009/1016
File chrome/common/extensions/docs/examples/extensions/buildbot/popup.html
(right):

http://codereview.chromium.org/411008/diff/1009/1016#newcode45
Line 45: anchor.onclick = showConsole;
On 2009/11/20 16:51:49, Erik Kay wrote:
> What do you think about using addListener("click") as a better style example?

I like it. Done.

http://codereview.chromium.org/411008/diff/1009/1016#newcode47
Line 47: anchor.appendChild(document.createTextNode("The tree is completely
green."));
On 2009/11/20 16:51:49, Erik Kay wrote:
> nit: 80 cols

Done.

[Erik does not do reviews, 2009-11-20 20:32:44]

LGTM

http://codereview.chromium.org/411008/diff/8001/8007
File chrome/common/extensions/docs/examples/extensions/buildbot/popup.html
(right):

http://codereview.chromium.org/411008/diff/8001/8007#newcode39
Line 39: while(bots.firstChild) {
you can just replace this with bots.innerText = "";

[rafaelw, 2009-11-20 21:37:15]

http://codereview.chromium.org/411008/diff/8001/8007
File chrome/common/extensions/docs/examples/extensions/buildbot/popup.html
(right):

http://codereview.chromium.org/411008/diff/8001/8007#newcode39
Line 39: while(bots.firstChild) {
On 2009/11/20 20:32:45, Erik Kay wrote:
> you can just replace this with bots.innerText = "";

Done.