chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html - Issue 411008: Remove use of innerHTML and Toolstrips from example extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html

Issue 411008: Remove use of innerHTML and Toolstrips from example extensions (Closed)

Patch Set: cr changes Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/examples/api/i18n/getMessage/manifest.json ('k') | chrome/common/extensions/docs/examples/api/messaging/timer/popup.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html

diff --git a/chrome/common/extensions/docs/examples/api/i18n/getMessage/toolstrip.html b/chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html

similarity index 54%

rename from chrome/common/extensions/docs/examples/api/i18n/getMessage/toolstrip.html

rename to chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html

index 970651a79cf770f8fecbd6fa66340b7f132436c5..f73477922a0e70b84e7926c6f90995fe675dac05 100644

--- a/chrome/common/extensions/docs/examples/api/i18n/getMessage/toolstrip.html

+++ b/chrome/common/extensions/docs/examples/api/i18n/getMessage/popup.html

@@ -6,23 +6,32 @@ LICENSE file.

<html>

<head>

+ <style>

+body {

+ color: black;

+ width: 300px;

+ </style>

+ function setChildTextNode(elementId, text) {

+ document.getElementById(elementId).innerText = text;

+ }

function init() {

- document.getElementById("languageSpan").innerHTML =

- chrome.i18n.getMessage("click_here");

+ setChildTextNode('languageSpan', chrome.i18n.getMessage("click_here"));

}

function getAcceptLanguages() {

chrome.i18n.getAcceptLanguages(function(languageList) {

var languages = languageList.join(",");

- document.getElementById("languageSpan").innerHTML =

- chrome.i18n.getMessage("chrome_accept_languages", languages);

+ setChildTextNode('languageSpan',

+ chrome.i18n.getMessage("chrome_accept_languages", languages));

})

}

</script>

</head>

- <div class="toolstrip-button" onclick="getAcceptLanguages();">

+ <div onclick="getAcceptLanguages();">

</div>

</body>