Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/content_settings.gypi

Issue 410993002: Componentize content_settings_types.h (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the dependency of content_settings.h on content_settings_types.h Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/components.gyp ('k') | components/content_settings/DEPS » ('j') | components/content_settings/DEPS » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings.gypi
diff --git a/components/search.gypi b/components/content_settings.gypi
similarity index 51%
copy from components/search.gypi
copy to components/content_settings.gypi
index 8cb0fe71e0ccc4c3ede8817c284faf90d5d4e623..478aa866f1a17912f27d32768b74b5c97edd4beb 100644
--- a/components/search.gypi
+++ b/components/content_settings.gypi
@@ -5,19 +5,15 @@
{
'targets': [
{
- 'target_name': 'search',
- 'type': 'static_library',
- 'dependencies': [
- '../base/base.gyp:base'
- ],
+ # GN version: //components/content_settings/core/common
+ 'target_name': 'content_settings_core_common',
+ 'type': 'none',
'include_dirs': [
'..',
],
'sources': [
- 'search/search.cc',
- 'search/search.h',
- 'search/search_switches.cc',
- 'search/search_switches.h',
+ # Note: sources list duplicated in GN build.
+ 'content_settings/core/common/content_settings_types.h',
],
},
],
« no previous file with comments | « components/components.gyp ('k') | components/content_settings/DEPS » ('j') | components/content_settings/DEPS » ('J')

Powered by Google App Engine
This is Rietveld 408576698