Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(339)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: components/content_settings/DEPS
Issue
410993002
:
Componentize content_settings_types.h (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove the dependency of content_settings.h on content_settings_types.h
Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
chrome/browser/BUILD.gn
chrome/browser/DEPS
chrome/browser/content_settings/content_settings_details.h
chrome/browser/content_settings/content_settings_mock_provider.h
chrome/browser/content_settings/content_settings_observer.h
chrome/browser/content_settings/content_settings_origin_identifier_value_map.h
chrome/browser/content_settings/content_settings_origin_identifier_value_map.cc
chrome/browser/content_settings/content_settings_provider.h
chrome/browser/content_settings/content_settings_usages_state.h
chrome/browser/content_settings/content_settings_utils.h
chrome/browser/content_settings/host_content_settings_map.h
chrome/browser/content_settings/mock_settings_observer.h
chrome/browser/content_settings/permission_bubble_request_impl.h
chrome/browser/content_settings/permission_context_base.h
chrome/browser/content_settings/permission_context_base_unittest.cc
chrome/browser/content_settings/permission_context_uma_util.h
chrome/browser/content_settings/permission_infobar_delegate.h
chrome/browser/content_settings/permission_queue_controller.h
chrome/browser/content_settings/permission_queue_controller_unittest.cc
chrome/browser/content_settings/tab_specific_content_settings.h
chrome/browser/extensions/api/content_settings/content_settings_helpers.h
chrome/browser/extensions/extension_special_storage_policy.cc
chrome/browser/extensions/extension_special_storage_policy_unittest.cc
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
chrome/browser/media/midi_permission_infobar_delegate.h
chrome/browser/notifications/desktop_notification_infobar_delegate.cc
chrome/browser/profiles/profile_io_data.h
chrome/browser/services/gcm/push_messaging_infobar_delegate.h
chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc
chrome/browser/ui/browser.h
chrome/browser/ui/browser_window.h
chrome/browser/ui/chrome_pages.h
chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm
chrome/browser/ui/cocoa/location_bar/content_setting_decoration.h
chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h
chrome/browser/ui/content_settings/content_setting_bubble_model_browsertest.cc
chrome/browser/ui/content_settings/content_setting_bubble_model_delegate.h
chrome/browser/ui/content_settings/content_setting_image_model.h
chrome/browser/ui/search/instant_controller.cc
chrome/browser/ui/views/content_setting_bubble_contents.h
chrome/browser/ui/views/location_bar/content_setting_image_view.h
chrome/browser/ui/views/website_settings/permission_selector_view.h
chrome/browser/ui/views/website_settings/website_settings_popup_view.cc
chrome/browser/ui/website_settings/permission_menu_model.h
chrome/browser/ui/website_settings/permission_menu_model_unittest.cc
chrome/browser/ui/website_settings/website_settings.h
chrome/browser/ui/website_settings/website_settings_ui.h
chrome/browser/ui/website_settings/website_settings_unittest.cc
chrome/browser/ui/webui/options/content_settings_handler.h
chrome/chrome_browser.gypi
chrome/chrome_common.gypi
chrome/common/BUILD.gn
chrome/common/DEPS
chrome/common/common_param_traits_macros.h
chrome/common/content_settings.h
chrome/common/content_settings_types.h
chrome/common/render_messages.h
chrome/renderer/DEPS
chrome/renderer/content_settings_observer.h
components/components.gyp
components/content_settings.gypi
components/content_settings/DEPS
components/content_settings/OWNERS
components/content_settings/core/common/BUILD.gn
components/content_settings/core/common/content_settings_types.h
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« components/content_settings.gypi
('k') |
components/content_settings/OWNERS »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: components/content_settings/DEPS
diff --git a/sync/base/DEPS b/components/content_settings/DEPS
similarity index 100%
copy from sync/base/DEPS
copy to components/content_settings/DEPS
« no previous file with comments
|
« components/content_settings.gypi
('k') |
components/content_settings/OWNERS »
('j') |
no next file with comments »
Issue 410993002: Componentize content_settings_types.h (Closed)
Created 6 years, 5 months ago by vasilii
Modified 6 years, 5 months ago
Reviewers: blundell, vabr (Chromium), nasko
Base URL: svn://svn.chromium.org/chrome/trunk/src
Comments: 12
This is Rietveld
408576698